Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunctions-tasks): support idle timeout for EmrCreateCluster #31142

Merged
merged 9 commits into from
Sep 13, 2024
Merged

feat(stepfunctions-tasks): support idle timeout for EmrCreateCluster #31142

merged 9 commits into from
Sep 13, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Aug 19, 2024

Issue # (if applicable)

Closes #29926 .

Reason for this change

To support IdleTimeout for EmrCreateCluster.

Ref: https://docs.aws.amazon.com/emr/latest/APIReference/API_RunJobFlow.html#EMR-RunJobFlow-request-AutoTerminationPolicy

Description of changes

Add autoTerminationPolicyIdleTimeout property to the EmrCreateCluster class.

Description of how you validated changes

Add unit tests and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mazyu36 mazyu36 changed the title chore(stepfunctions-tasks): support idle timeout for EmrCreateCluster feat(stepfunctions-tasks): support idle timeout for EmrCreateCluster Aug 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 19, 2024 05:37
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Aug 19, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Open
go-to-k
go-to-k suggested changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I just made a few minor comments.

packages/aws-cdk-lib/aws-stepfunctions-tasks/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 31, 2024
mazyu36 and others added 5 commits September 1, 2024 11:27
@mazyu36 @go-to-k
Update packages/aws-cdk-lib/aws-stepfunctions-tasks/README.md
b1bbe19 
Co-authored-by: Kenta Goto (k.goto) <24818752+go-to-k@users.noreply.github.com>
@mazyu36 @go-to-k
Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/emr/emr-creat…
7a13ac3 
…e-cluster.ts

Co-authored-by: Kenta Goto (k.goto) <24818752+go-to-k@users.noreply.github.com>
@mazyu36 @go-to-k
Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/emr/emr-creat…
54c5caa 
…e-cluster.ts

Co-authored-by: Kenta Goto (k.goto) <24818752+go-to-k@users.noreply.github.com>
@mazyu36 @go-to-k
Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/emr/emr-creat…
7ee0147 
…e-cluster.ts

Co-authored-by: Kenta Goto (k.goto) <24818752+go-to-k@users.noreply.github.com>
@mazyu36
Update emr-create-cluster.test.ts
189aff8
@github-actions github-actions bot mentioned this pull request Sep 1, 2024
Open
@mazyu36
Copy link
Contributor Author

mazyu36 commented Sep 1, 2024 •
edited
Loading

@go-to-k
Thank you for the review.
I have incorporated the suggestions and fixed the unit test for the error message.​​​​​​​​​​​​​​​​

@mazyu36 mazyu36 requested a review from go-to-k September 1, 2024 04:17
go-to-k
go-to-k approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 1, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36
Copy link
Contributor Author

mazyu36 commented Sep 13, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 13, 2024

update

✅ Branch has been successfully updated

@mazyu36
Copy link
Contributor Author

mazyu36 commented Sep 13, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 13, 2024

refresh

✅ Pull request refreshed

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 13, 2024

refresh

✅ Pull request refreshed

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 95476ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 432ffaf into aws:main Sep 13, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2024
@mazyu36 mazyu36 deleted the create-emr-cluster-idle-timeout-29926 branch September 13, 2024 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@go-to-k go-to-k go-to-k approved these changes

@GavinZZ GavinZZ GavinZZ approved these changes

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stepfunctions-tasks: emr-create-cluster - add support for AutoTerminationPolicy.IdleTimeout
4 participants
@mazyu36 @aws-cdk-automation @go-to-k @GavinZZ