Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): bucket notifications in owning stack deletes bucket notifications from other stacks #31091

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Aug 12, 2024

Issue # (if applicable)

Closes #30607.

Reason for this change

There's a bug reported in the Github issue that bucket notifications in owing stack will remove all notifications added in imported stack. This is because we treated the bucket as managed hence we use bucket notifications in that stack as source of truth.

In the unmanaged path, we already filtered out external notifications it should handle both scenarios when the bucket is managed or unmanaged.

Description of changes

Always set Managed property to false when the feature flag is enabled. Here we introduce a feature flag to prevent it breaking current customers.

Description of how you validated changes

Added unit tests. Integrations test can't validate this change because we need to deploy twice to actually see the change.
Also tested manually.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 12, 2024 22:45
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Aug 12, 2024
@xazhao xazhao changed the title fix(s3): BucketNotification in owning stack deletes BucketNotificatio… fix(s3): BucketNotification in owning stack deletes BucketNotifications from other stacks Aug 12, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 12, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@xazhao xazhao changed the title fix(s3): BucketNotification in owning stack deletes BucketNotifications from other stacks fix(s3): bucket notifications in owning stack deletes bucket notifications from other stacks Aug 12, 2024
@xazhao xazhao added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Aug 22, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 22, 2024 00:10

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 27, 2024
Copy link
Contributor

mergify bot commented Aug 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 27, 2024
Copy link
Contributor

mergify bot commented Aug 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1e9e12e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Aug 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0b09e52 into aws:main Aug 27, 2024
9 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_s3: BucketNotification in owning stack deletes BucketNotifications from other stacks
3 participants