Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): add enableAcceptanceRequired function for VpcEndpointService #30923

Closed
wants to merge 11 commits into from

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Jul 22, 2024

Issue # (if applicable)

Closes #30192.

Reason for this change

Adding this feature in aws_ec2.VpcEndpointService will bring it to the level of console and lower level construct. With this feature, I can disable it in CDK for a short time to add intended connections and enable it again for security. Currently, someone with admin privileges need to monitor the console for requests, accept it manually and then ket the deployment continue which adds unnecessary overhead to automating the process.

Description of changes

Add enableAcceptanceRequired method to the ec2.VpcEndpointService class.

Description of how you validated changes

Add both unit and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jul 22, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 22, 2024 21:40
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review July 22, 2024 21:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer changed the title feat(ec2): modify acceptanceRequired for VpcEndpointService feat(ec2): add enableAcceptanceRequired function for VpcEndpointService Jul 22, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 24, 2024
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Left a couple of suggestions on the documentation

packages/aws-cdk-lib/aws-ec2/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ec2/README.md Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 27, 2024
badmintoncryer and others added 2 commits July 28, 2024 02:43
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@badmintoncryer
Copy link
Contributor Author

@lpizzinidev Thank you for your review!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: da422eb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@Leo10Gama Leo10Gama self-assigned this Jul 29, 2024
@Leo10Gama
Copy link
Member

Closing this PR as, unfortunately, we cannot accept changes like this. By allowing this value to be altered later in execution, it becomes unclear what the source of truth is for this property. There isn't a good enough reason to change the value outside of the constructor, and while adding in this functionality would cover a few specific use cases of toggling it off and on to add connections, it would ultimately degrade the user experience overall.

@Leo10Gama Leo10Gama closed this Jul 30, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ec2.VpcEndpointService: Modify endpoint acceptance setting
4 participants