-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipes-targets): add API Gateway #30772
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs don't explicitly mention that the target can only be a REST API, it might work with WebSockets? If that's the case, could you add an integ and the likes?
packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.api-gateway.ts
Outdated
Show resolved
Hide resolved
Good shout about the docs. I did create a WebSocket API and it wasn't available in the Console when I tried to create a Pipe target. The CFN docs do state only REST APIs. @redwheeler3, can you confirm if REST APIs are the only type supported here? |
grantPush(grantee: IRole): void { | ||
grantee.addToPrincipalPolicy(new PolicyStatement({ | ||
resources: [this.restApiArn], | ||
actions: ['execute-api:Invoke'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmussy updated this to just Invoke
'x-header': 'myheader', | ||
}, | ||
queryStringParameters: { key: 'USA' }, | ||
pathParameterValues: ['fiction'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmussy I think this is what you're after? fiction
replaces the *
in path
defined above. More coverage..
Pipes does not support WebSocket APIs. |
The |
3469f1a
to
a254134
Compare
a254134
to
a253bc6
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Add API Gateway REST API as a Pipes target.