-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipes-targets): add SageMaker #30696
Open
msambol
wants to merge
6
commits into
aws:main
Choose a base branch
from
msambol:pipes-targets-sagemaker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p2
distinguished-contributor
[Pilot] contributed 50+ PRs to the CDK
labels
Jun 27, 2024
aws-cdk-automation
added
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
and removed
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
labels
Jun 27, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
I saw these errors when working on #30696.
aws-cdk-automation
added
the
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
label
Jun 29, 2024
nmussy
suggested changes
Jun 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall 👍
aws-cdk-automation
removed
the
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
label
Jun 29, 2024
This was referenced Jul 1, 2024
msambol
force-pushed
the
pipes-targets-sagemaker
branch
from
July 1, 2024 15:13
51eda21
to
ee3e753
Compare
@nmussy – updated per your feedback. Thanks as always! |
nmussy
reviewed
Jul 1, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
pahud
added
the
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
label
Jul 22, 2024
aws-cdk-automation
removed
the
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
label
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SageMaker pipeline as a Pipes target.