feat(dynamodb): enable contributor insights for global secondary index #30560
+605
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
star-contributor
github-actions
bot
added
effort/small
aws-cdk-automation
added
the
pr/needs-community-review
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
badmintoncryer
suggested changes
Sep 21, 2024
...esting/framework-integ/test/aws-dynamodb/test/integ.dynamodb.contirubtor-insights-for-gsi.ts
Outdated
Show resolved
Hide resolved
| import { IntegTest } from '@aws-cdk/integ-tests-alpha'; | ||
|
|
||
| // CDK parameters | ||
| const STACK_NAME = 'aws-cdk-dynamodb-contributor-insights-for-gis'; |
There was a problem hiding this comment.
What is the meaning of gis? If it means global secondary index, it is better to use gsi.
There was a problem hiding this comment.
As you pointed out, it was a mistake.
I have corrected it.
| partitionKey: GSI_PARTITION_KEY, | ||
| }); | ||
|
|
||
| new IntegTest(app, 'aws-cdk-dynamodb-contributor-insights-for-gis-test', { |
There was a problem hiding this comment.
Just like above, I'm only concerned about gis.
Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
…st/integ.dynamodb.contirubtor-insights-for-gsi.ts Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
mazyu36
force-pushed
the
dynamodb-cw-insights-for-gsi-15671
branch
from
072b75e
to
716c60f
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
removed
the
pr/needs-community-review
|
@badmintoncryer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #15671 .
Reason for this change
To enable contributor insights for a specific global secondary index.
This feature is supported in CFn.
Description of changes
Add
contributorInsightsEnabledproperty to theGlobalSecondaryIndexPropsinTable.In AWS::DynamoDB::GlobalTable GlobalSecondaryIndex,
ContributorInsightsSpecificationdoes not exist.So I didn't change
TableV2.Description of how you validated changes
Add unit test and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license