fix(iam): incorrect input for AccountPrincipal is building successfully #30559

duranbe · 2024-06-15T21:19:00Z

Reason for this change

There is no validation and test that the AWS Account Id when creating AccountPrincipal Object. In my case I missed a digit when copy pasting an account id and the build still passed, the typo has been caught only during the code review process

Description of changes

Adding simple regex to check that AWS Id is 12 digits long & update error message

Description of how you validated changes

Existing tests are passing and added 2 of them

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

duranbe · 2024-06-15T21:46:38Z

Logs are quite odd

[4/4] Building fresh packages...
error /codebuild/output/src3225815236/src/github.com/aws/aws-cdk/node_modules/@lerna/create/node_modules/nx, /codebuild/output/src3225815236/src/github.com/aws/aws-cdk/node_modules/@nx/devkit/node_modules/nx, /codebuild/output/src3225815236/src/github.com/aws/aws-cdk/node_modules/lerna/node_modules/nx: Command failed.
Exit code: 135
Command: node ./bin/post-install
Arguments: 
Directory: /codebuild/output/src3225815236/src/github.com/aws/aws-cdk/node_modules/@lerna/create/node_modules/nx
Output:
Bus error (core dumped)
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Seems issue with yarn/nx

TheRealAmazonKendra · 2024-06-21T21:18:26Z

packages/aws-cdk-lib/aws-iam/lib/principals.ts

  /**
   *
   * @param accountId AWS account ID (i.e. '123456789012')
   */
  constructor(public readonly accountId: any) {
    super(new StackDependentToken(stack => `arn:${stack.partition}:iam::${accountId}:root`).toString());
-    if (!cdk.Token.isUnresolved(accountId) && typeof accountId !== 'string') {
-      throw new Error('accountId should be of type string');
+    if (!cdk.Token.isUnresolved(accountId) && typeof accountId !== 'string' && !this.accountIdRegExp.test(accountId)) {


While you're at it, maybe we should check to see that all characters in the string are digits.

It's covered with the regex new RegExp('^[0-9]{12}$'); as restricting only digits to 0-9 (could also be \d, but 0-9 is easier to read imo)

TheRealAmazonKendra · 2024-06-21T21:19:01Z

This build failure can't possibly have anything to do with this change... I'll retrigger it.

TheRealAmazonKendra · 2024-06-21T21:19:08Z

@Mergifyio update

mergify · 2024-06-21T21:19:17Z

update

✅ Branch has been successfully updated

TheRealAmazonKendra · 2024-06-21T21:19:54Z

For fixes, the title should describe the bug, not the solution. Could you please update it?

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

duranbe · 2024-06-24T15:32:20Z

Hey Kendra, thanks for the review and restarting the build

For fixes, the title should describe the bug, not the solution. Could you please update it?

Done ! Is it better with this ?

fix(iam): incorrect input for AccountPrincipal is building successfully

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Pull request has been modified.

duranbe · 2024-06-29T10:52:00Z

Seems this PR is breaking lots of existing test ... I'll look into it, if it's too complex or there is actual use case where the an AWS ID is not 12 digits (which should not be the case ?) I'll close it.

...-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-ecr-source.ts

...testing/framework-integ/test/aws-codepipeline-actions/test/cloudformation/integ.stacksets.ts

duranbe · 2024-07-17T18:49:48Z

@TheRealAmazonKendra can you take a quick look ? PR seems big (🥲) but 99% is just updating existing test

aws-cdk-automation · 2024-08-19T00:10:12Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2024-08-25T00:10:50Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

…rror (aws#30726) Closes aws#30717. esbuild introduced a breaking change in v0.22 which caused the build error in `aws-lambda-nodejs` module. Pin the esbuild version to 0.21 in Dockerfile - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

They have now been standardized for a few years. We did not initially remove the old mappings out of caution and because we were unsure that the changes has made it to all regions yet. It is long past that happening at this point. Because we never removed this or marked it as deprecated, we still have a not insignificant amount of customers who believe the individual mapping is necessary and cut tickets because it is not up-to-date. Closes #<issue number here>. - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Closes aws#30331. This will improve the security group lookup functionality for importing existing security groups into a CDK stack. I added the ability to lookup existing security groups via more filters. Filters are supported by the [DescribeSecurityGroups API](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeSecurityGroups.html), and using these filters can be immensely useful for looking up existing security groups, especially if your account or organization follows predictable rules regarding things like security group tags. I added unit tests similar to the ones that test the normal lookup by ID or name. - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

aws-cdk-automation · 2024-08-25T18:15:06Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: eb7276b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2024-09-01T00:12:25Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2024-09-02T00:21:39Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

github-actions · 2024-09-04T19:31:41Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 15, 2024

aws-cdk-automation requested a review from a team June 15, 2024 21:19

github-actions bot added the p2 label Jun 15, 2024

aws-cdk-automation previously requested changes Jun 15, 2024

View reviewed changes

aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jun 15, 2024

duranbe changed the title ~~fix(iam) add 12-digits validation for AccountPrincipal~~ fix(iam): add 12-digits validation for AccountPrincipal Jun 15, 2024

github-actions bot mentioned this pull request Jun 17, 2024

Weekly PR metrics report #30566

Closed

TheRealAmazonKendra previously requested changes Jun 21, 2024

View reviewed changes

TheRealAmazonKendra added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Jun 21, 2024

duranbe changed the title ~~fix(iam): add 12-digits validation for AccountPrincipal~~ fix(iam): Incorrect input for AccountPrincipal is not failing build/validation Jun 24, 2024

aws-cdk-automation previously requested changes Jun 24, 2024

View reviewed changes

duranbe changed the title ~~fix(iam): Incorrect input for AccountPrincipal is not failing build/validation~~ fix(iam): incorrect input for AccountPrincipal is not failing build/validation Jun 24, 2024

duranbe changed the title ~~fix(iam): incorrect input for AccountPrincipal is not failing build/validation~~ fix(iam): incorrect input for AccountPrincipal is building successfully Jun 24, 2024

duranbe force-pushed the fix-account-principal branch from 206cce4 to 17c7271 Compare June 26, 2024 21:28

duranbe had a problem deploying to test-pipeline June 30, 2024 22:08 — with GitHub Actions Failure

duranbe commented Jun 30, 2024

View reviewed changes

...-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-ecr-source.ts Show resolved Hide resolved

duranbe commented Jun 30, 2024

View reviewed changes

...testing/framework-integ/test/aws-codepipeline-actions/test/cloudformation/integ.stacksets.ts Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Jul 1, 2024

Monthly PR metrics report #30715

Closed

duranbe had a problem deploying to test-pipeline July 1, 2024 07:53 — with GitHub Actions Failure

fix indent

1f73435

duranbe had a problem deploying to test-pipeline July 14, 2024 13:32 — with GitHub Actions Failure

Merge branch 'main' into fix-account-principal

8a6861a

duranbe had a problem deploying to test-pipeline July 15, 2024 18:45 — with GitHub Actions Failure

Merge branch 'main' into fix-account-principal

04d3573

duranbe had a problem deploying to test-pipeline July 17, 2024 18:14 — with GitHub Actions Failure

Merge branch 'main' into fix-account-principal

9a71f48

duranbe had a problem deploying to test-pipeline July 22, 2024 19:17 — with GitHub Actions Failure

Merge branch 'main' into fix-account-principal

dfd66cb

duranbe had a problem deploying to test-pipeline July 27, 2024 10:00 — with GitHub Actions Failure

Merge branch 'main' into fix-account-principal

4c9b2ca

duranbe had a problem deploying to test-pipeline July 30, 2024 13:36 — with GitHub Actions Failure

Merge branch 'main' into fix-account-principal

b73f17f

duranbe had a problem deploying to test-pipeline August 8, 2024 08:54 — with GitHub Actions Failure

xazhao and others added 5 commits August 25, 2024 20:01

Update principals.test.ts

454744b

fix indent

1aa09bb

duranbe requested a deployment to test-pipeline August 25, 2024 18:05 — with GitHub Actions Waiting

duranbe closed this Sep 4, 2024

github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024

duranbe deleted the fix-account-principal branch September 4, 2024 21:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(iam): incorrect input for AccountPrincipal is building successfully #30559

fix(iam): incorrect input for AccountPrincipal is building successfully #30559

duranbe commented Jun 15, 2024

aws-cdk-automation left a comment

duranbe commented Jun 15, 2024

TheRealAmazonKendra Jun 21, 2024

duranbe Jun 24, 2024 •

edited

Loading

TheRealAmazonKendra commented Jun 21, 2024

TheRealAmazonKendra commented Jun 21, 2024

mergify bot commented Jun 21, 2024

TheRealAmazonKendra commented Jun 21, 2024

aws-cdk-automation left a comment

duranbe commented Jun 24, 2024 •

edited

Loading

duranbe commented Jun 29, 2024

duranbe commented Jul 17, 2024

aws-cdk-automation commented Aug 19, 2024

aws-cdk-automation commented Aug 25, 2024

aws-cdk-automation commented Aug 25, 2024

aws-cdk-automation commented Sep 1, 2024

aws-cdk-automation commented Sep 2, 2024

github-actions bot commented Sep 4, 2024

fix(iam): incorrect input for AccountPrincipal is building successfully #30559

fix(iam): incorrect input for AccountPrincipal is building successfully #30559

Conversation

duranbe commented Jun 15, 2024

Reason for this change

Description of changes

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

duranbe commented Jun 15, 2024

TheRealAmazonKendra Jun 21, 2024

Choose a reason for hiding this comment

duranbe Jun 24, 2024 • edited Loading

Choose a reason for hiding this comment

TheRealAmazonKendra commented Jun 21, 2024

TheRealAmazonKendra commented Jun 21, 2024

mergify bot commented Jun 21, 2024

✅ Branch has been successfully updated

TheRealAmazonKendra commented Jun 21, 2024

aws-cdk-automation left a comment

Choose a reason for hiding this comment

duranbe commented Jun 24, 2024 • edited Loading

duranbe commented Jun 29, 2024

duranbe commented Jul 17, 2024

aws-cdk-automation commented Aug 19, 2024

aws-cdk-automation commented Aug 25, 2024

aws-cdk-automation commented Aug 25, 2024

AWS CodeBuild CI Report

aws-cdk-automation commented Sep 1, 2024

aws-cdk-automation commented Sep 2, 2024

github-actions bot commented Sep 4, 2024

duranbe Jun 24, 2024 •

edited

Loading

duranbe commented Jun 24, 2024 •

edited

Loading