Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route53): adding access logging possibility to the resulting Cloudfront distribution created by the redirect construct #29743

Conversation

roland-gharfine
Copy link

@roland-gharfine roland-gharfine commented Apr 5, 2024

Issue # (if applicable)

N/A

Reason for this change

For compliance and security reasons, an organisation might want to enable access logging on all Cloudfront distributions. This PR allows to maintain governance and adherence to security configuration standards without manual intervention.

Description of changes

  • Allowing the callers of the patterns.HttpsRedirect() construct to pass an optional parameter of type LoggingConfig (existing interface)
  • Creating an object of type
  • Setting the loggingConfig property of this object if it's passed to the construct
  • Calling the CloudFrontWebDistribution() construct with the CloudFrontWebDistributionProps object rather than setting the properties inline

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@roland-gharfine roland-gharfine changed the title feat(route53): Adding access logging possibility to the resulting Cloudfront distribution created by the redirect construct feat(route53): adding access logging possibility to the resulting Cloudfront distribution created by the redirect construct Apr 5, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3207769
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 5, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants