chore(ec2): add missing instance types #29427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
distinguished-contributor
aws-cdk-automation
added
the
pr/needs-community-review
github-actions
bot
added
effort/medium
msambol
reviewed
Mar 11, 2024
msambol
reviewed
Mar 11, 2024
msambol
reviewed
Mar 11, 2024
msambol
reviewed
Mar 11, 2024
aws-cdk-automation
removed
the
pr/needs-community-review
msambol
reviewed
Mar 11, 2024
msambol
reviewed
Mar 11, 2024
aws-cdk-automation
added
the
pr/needs-maintainer-review
paulhcsun
approved these changes
Mar 11, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 task
mergify bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
### Issue # (if applicable) None ### Reason for this change Follow up to #29427. Added a missing instance type, and minor fixes to the `IntanceType` class ### Description of changes I'd missed an instance type, [`dl2q`](https://aws.amazon.com/ec2/instance-types/dl2q/), which was neither in `us-east-1` or `us-east-2`, but in `us-west-2`. I've also added a couple of missing symbolic names, as well as fixed some differing comments between the key and its symbolic value (e.g. `M3` and `STANDARD3`) I also re-ordered a couple of enum values, when the symbolic value was separated from its match ### Description of how you validated changes Compared the CDK to the SDK to find the missing instance. Programmatically iterated over the comments of `IntanceType` to make sure the comments of the symbolic keys matched the one below. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #23854
Reason for this change
Update the CDK EC2 instance class and size enums to match the current availability
Description of changes
Added the missing instance class and sizes
Description of how you validated changes
This was generated with the help of the same tool I used to create #29422, using the live SDK data to match against the CDK. For the instance types, I am using the
DescribeInstanceTypesAPI command in multiple regions (us-east-1,us-east-2,us-west-1,eu-west-1.) As far as I could tell, the union ofus-east-1andus-east-2cover all possible instance classes and sizes, but correct me if I'm wrong.As a sanity check, I'm also checking that the CDK does not have more instance types and sizes that the SDK does. It does vary between regions, but of note, there were:
p4de, in developer previewx2g, RDS exclusive and not returned byDescribeInstanceTypesFinally, I am ignoring some of the previous generation instance classes missing from the CDK, as they are very outdated and weren't added in first place, i.e.
c1,t1,m1,m2, andi2.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license