chore: lint against constructing lambda handlers #28374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a custom lint rule that bans construction of constructs that create lambda handlers. This is to be used within `aws-cdk-lib` to push authors towards using our standard way of vending handlers using codegen tools in @aws-cdk/handler-framework.
MrArnoldPalmer
force-pushed
the
chore/internal-handler-linting
branch
from
8d33130
to
5935d88
Compare
kaizencc
approved these changes
Dec 18, 2023
|
working on a small bug here that needs to be addressed for relative imports within |
|
@MrArnoldPalmer it looks like #28251 has been merged. If you're still working on this could you have a look at the merge conflicts so that this PR can be merged? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
paulhcsun
requested changes
Mar 7, 2024
There was a problem hiding this comment.
@MrArnoldPalmer looks like a couple integ tests in @aws-cdk/aws-s3objectlambda-alpha violate the new linter rule. Could you have a look and update those files?
|
Closing this PR for staleness, please open a new PR if you'd like to continue working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a custom lint rule that bans construction of constructs that create
lambda handlers. This is to be used within
aws-cdk-libto push authorstowards using our standard way of vending handlers using codegen tools
in @aws-cdk/handler-framework.
NOTE: depends on #28251
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license