chore(app-staging-synthesizer): reduce the size of DefaultStagingStack template by 5KB #26024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kaizencc
commented
Jun 16, 2023
packages/@aws-cdk/app-staging-synthesizer-alpha/lib/default-staging-stack.ts
Outdated
Show resolved
Hide resolved
rix0rrr
requested changes
Jun 18, 2023
packages/@aws-cdk/app-staging-synthesizer-alpha/lib/default-staging-stack.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/app-staging-synthesizer-alpha/lib/default-staging-stack.ts
Outdated
Show resolved
Hide resolved
rix0rrr
approved these changes
Jun 20, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
DefaultStagingStackis a stack that creates staging resources, it is bound to the CloudFormation limit of 51KB. This means that there is an upper limit on how many ECR repositories (and in turn, unique images) are allowed in the CDK App. In an effort to increase this limit, this PR does the following:AWS::CDK::Metadataconstruct to save ~3KBUsingDefaultStagingStackconstruct to the stacks that use theDefaultStagingStackfor analytics purposes.In all, this should decrease the size of the DefaultStagingStack template by ~5KB, or ~10% of the overall size allowed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license