Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelines): Add feature to display all changesets for stage before manual approval step + added postPrepare Step #25413 #25852

Closed
wants to merge 30 commits into from

Conversation

Nico-DB
Copy link

@Nico-DB Nico-DB commented Jun 5, 2023

Describe the feature

I would like to "run" all changesets of a stage at first, then have a manual approval step and then perform the execute change set in the original run-order.

Use Case

The use case is, that we would like to check the changesets for all stacks of an environment, to be able to perform a qualified manual approval.

Closes #24072.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 5, 2023

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 5, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 5, 2023 11:28
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Nico-DB
Copy link
Author

Nico-DB commented Jun 5, 2023

@rix0rrr I have created some new integ tests for the pipelines construct. Since the cdk-pipelines-demo repo is private, i cannot generate the snapshots. Can you please run the tests?

@Nico-DB
Copy link
Author

Nico-DB commented Jun 5, 2023

@hoegertn Here is the new pr

@Nico-DB
Copy link
Author

Nico-DB commented Jun 6, 2023

@rix0rrr Could you also please rerun the integ tests which are failing because of a change to the naming of the prepare-steps

@Nico-DB
Copy link
Author

Nico-DB commented Jun 19, 2023

Exemption Request:
I am not able to adapt the needed snapshots since the pipelines does point to a privat repository by rix0rrr

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jun 19, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 22, 2023 12:32

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 95825a8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@Nico-DB
Copy link
Author

Nico-DB commented Jul 28, 2023

This should stay open.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(pipelines): (Add feature to display all changesets for stage before manual approval step)
2 participants