Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(assertions): update link to migration guide #25602

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

madeline-k
Copy link
Contributor

The link to the @aws-cdk/assert -> aws-cdk-lib.assertions migration guide was incorrect, and sent you to a 404 page. The migration guide only exists on the v1-main branch now, since the @aws-cdk/assert library is not published with v2.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The link to the `@aws-cdk/assert` -> `aws-cdk-lib.assertions` migration guide was incorrect. The migration guide only exists on the `v1-main` branch now, since the `@aws-cdk/assert` library is not published with v2.
@madeline-k madeline-k requested a review from a team May 15, 2023 22:43
@gitpod-io
Copy link

gitpod-io bot commented May 15, 2023

@github-actions github-actions bot added the p2 label May 15, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 15, 2023 22:43
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 15, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 15, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e075cf0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b885ece into main May 15, 2023
@mergify mergify bot deleted the madeline-k-patch-1 branch May 15, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants