Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): 2.62.1 #23848

Merged
merged 2 commits into from
Jan 26, 2023
Merged

chore(release): 2.62.1 #23848

merged 2 commits into from
Jan 26, 2023

Commits on Jan 26, 2023

  1. fix: aws-cdk-lib imports from ESM modules are broken (#23846) 

    PR #23813 made imports lazy, but in the resulting code, Nodejs no longer recognizes the exports when importing `aws-cdk-lib` from an ESM module.

To solve this, vend two different index files: one for use by CJS imports, one for use by ESM imports.

ESM modules will still try to load the entire library, so they don't benefit from the speed boost. This is unavoidable: we tried a more complex method that forced ESM to recognize the lazy module references anyway (by tricking the backwards compatibility lexer), but ESM did not experience a speed boost, indicating that it was crawling the entire module irrespective of the submodule accessor's laziness. So, we are opting for the simpler solution of vending two index files instead.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @rix0rrr @mrgrain
    rix0rrr authored and mrgrain committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    46b93a9 View commit details
    Browse the repository at this point in the history

  2. chore(release): 2.62.1

    @mrgrain
    mrgrain committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    740974f View commit details
    Browse the repository at this point in the history