fix(aws-eks): nodegroupName attribute correctly assigned #22910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aws-cdk-automation
previously requested changes
Nov 14, 2022
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TheRealAmazonKendra
requested changes
Jan 12, 2023
| @@ -197,6 +197,8 @@ class EksClusterStack extends Stack { | |||
| minSize: 1, | |||
| // reusing the default capacity nodegroup instance role when available | |||
| nodeRole: this.cluster.defaultCapacity ? this.cluster.defaultCapacity.role : undefined, | |||
| // custom nodegropuName | |||
| nodegroupName: 'extra-ng', | |||
There was a problem hiding this comment.
Let's add an assert to this test that checks that this is correctly set.
| @@ -569,6 +569,7 @@ | |||
| "./aws-opensearchservice": "./aws-opensearchservice/index.js", | |||
| "./aws-opsworks": "./aws-opsworks/index.js", | |||
| "./aws-opsworkscm": "./aws-opsworkscm/index.js", | |||
| "./aws-organizations": "./aws-organizations/index.js", | |||
There was a problem hiding this comment.
This file shouldn't be included in this commit.
|
@pahud given the age of this one and the merge conflicts, I'm going to close this. Please feel free to re-open it if you plan to continue working on it! |
1 task
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
### Issue # (if applicable) As #22910 and #25278 were closed for staleness. I am opening a new PR to fix #22442. To avoid breaking change, this PR introduces a new feature flag for the bug fix. Closes #22442 ### The Code for verification ```ts import { App, Stack, aws_eks as eks, aws_ec2 as ec2, CfnOutput, cx_api, } from 'aws-cdk-lib'; const app = new App(); const env = { region: process.env.CDK_DEFAULT_REGION, account: process.env.CDK_DEFAULT_ACCOUNT }; const stack = new Stack(app, 'my-test-stack2', { env }); stack.node.setContext(cx_api.EKS_NODEGROUP_NAME, true); const vpc = ec2.Vpc.fromLookup(stack, 'Vpc', { isDefault: true }); const cluster = new eks.Cluster(stack, 'Cluster', { vpc, version: eks.KubernetesVersion.V1_29, defaultCapacity: 0, }); const ng1 = new eks.Nodegroup(stack, 'ng-1', { cluster, }); const ng2 = cluster.addNodegroupCapacity('ng-2', { nodegroupName: 'custom-name', }); new CfnOutput(stack, 'ng1-name', { value: ng1.nodegroupName }); new CfnOutput(stack, 'ng2-name', { value: ng2.nodegroupName }); ``` The output is like ``` Outputs: my-test-stack2.ng1name = ng19F1EA947-sSziNMzPVkik my-test-stack2.ng2name = custom-name ``` Console: <img width="315" alt="image" src="https://github.com/aws/aws-cdk/assets/278432/019255bd-7d05-43ad-8624-baf5b6eea725"> ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
nodegroupNameattribute was incorrectly assigned.I am not sure if this will cause breaking changes. Please kindly advise.
Fixes: #22442
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license