Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_applicationautoscaling: Enable SageMaker high resolution predefined metric #31113

Closed
1 of 2 tasks
shahks opened this issue Aug 14, 2024 · 3 comments · Fixed by #31115
Closed
1 of 2 tasks

aws_applicationautoscaling: Enable SageMaker high resolution predefined metric #31113

shahks opened this issue Aug 14, 2024 · 3 comments · Fixed by #31115
Labels
@aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@shahks
Copy link
Contributor

shahks commented Aug 14, 2024

Describe the feature

Add missing Predefined metrics for Application Autoscaling as per https://docs.aws.amazon.com/autoscaling/application/APIReference/API_PredefinedMetricSpecification.html

Use Case

I would like to use autoscaling along with high resolution metrics for SageMaker endpoints.

Proposed Solution

aws_cdk.aws_applicationautoscaling.PredefinedMetric.SAGEMAKER_INFERENCE_COMPONENT_CONCURRENT_REQUESTS_PER_COPY_HIGH_RESOLUTION enum value could be added.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.151.0

Environment details (OS name and version, etc.)

N/A
@shahks shahks added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 14, 2024
@github-actions github-actions bot added the @aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling label Aug 14, 2024
@shahks shahks mentioned this issue Aug 14, 2024
Merged
@ashishdhingra ashishdhingra self-assigned this Aug 14, 2024
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 14, 2024
@ashishdhingra
Copy link
Contributor

@shahks Thanks for the PR contribution.

@ashishdhingra ashishdhingra added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Aug 14, 2024
@ashishdhingra ashishdhingra removed their assignment Aug 14, 2024
@github-actions github-actions bot mentioned this issue Aug 19, 2024
Open
@mergify mergify bot closed this as completed in #31115 Aug 19, 2024
@mergify mergify bot closed this as completed in c1c800e Aug 19, 2024
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
GavinZZ pushed a commit that referenced this issue Aug 20, 2024
@shahks @GavinZZ
chore(applicationautoscaling): add missing PredefinedMetricType enum …
b21e8c5 
…values (#31115)

### Issue # (if applicable)

Closes #31113

### Reason for this change

There are three `PredefinedMetricType` values missing from the enum:

* SageMakerInferenceComponentConcurrentRequestsPerCopyHighResolution
* SageMakerVariantConcurrentRequestsPerModelHighResolution
* WorkSpacesAverageUserSessionsCapacityUtilization

https://docs.aws.amazon.com/autoscaling/application/APIReference/API_PredefinedMetricSpecification.html

### Description of changes

Adds the missing enums

### Description of how you validated changes

Added unit tests

### Checklist
- [ X ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(applicationautoscaling): add missing PredefinedMetricType enum values shahks/aws-cdk
2 participants
@shahks @ashishdhingra