Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docdb: support for specifying storage type for Cluster #30165

Closed
1 of 2 tasks
badmintoncryer opened this issue May 12, 2024 · 3 comments · Fixed by #30163
Closed
1 of 2 tasks

docdb: support for specifying storage type for Cluster #30165

badmintoncryer opened this issue May 12, 2024 · 3 comments · Fixed by #30163
Labels
@aws-cdk/aws-docdb Related to Amazon DocumentDB effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

Specify storage type for DocDB cluster from L2 construct.

Use Case

DocDB cluster supports for specifying storage type but CDK cannot configure it.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.141.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 12, 2024
@github-actions github-actions bot added the @aws-cdk/aws-docdb Related to Amazon DocumentDB label May 12, 2024
@badmintoncryer badmintoncryer mentioned this issue May 12, 2024
Merged
1 task
This was referenced May 13, 2024
Closed
Closed
@pahud
Copy link
Contributor

pahud commented May 13, 2024

Again, @badmintoncryer We're looking forward to your PR as always. Thank you!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 13, 2024
@github-actions github-actions bot mentioned this issue Jun 1, 2024
Closed
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
@mergify mergify bot closed this as completed in #30163 Sep 4, 2024
@mergify mergify bot closed this as completed in 7ed221c Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
pahud pushed a commit to pahud/aws-cdk that referenced this issue Sep 9, 2024
@badmintoncryer @pahud
feat(docdb): i/o optimized storage type (aws#30163)
eb3a532 
### Issue # (if applicable)

Closes aws#30165.

### Reason for this change

Document DB can use I/O optimized storage type but CDK cannot configure that.

### Description of changes

Add `storageType` to `ClusterProps`.

### Description of how you validated changes

Add both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
xazhao pushed a commit to xazhao/aws-cdk that referenced this issue Sep 12, 2024
@badmintoncryer @xazhao
feat(docdb): i/o optimized storage type (aws#30163)
e92c7ad 
### Issue # (if applicable)

Closes aws#30165.

### Reason for this change

Document DB can use I/O optimized storage type but CDK cannot configure that.

### Description of changes

Add `storageType` to `ClusterProps`.

### Description of how you validated changes

Add both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
GavinZZ pushed a commit that referenced this issue Sep 12, 2024
@badmintoncryer @GavinZZ
feat(docdb): i/o optimized storage type (#30163)
746f4cc 
### Issue # (if applicable)

Closes #30165.

### Reason for this change

Document DB can use I/O optimized storage type but CDK cannot configure that.

### Description of changes

Add `storageType` to `ClusterProps`.

### Description of how you validated changes

Add both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-docdb Related to Amazon DocumentDB effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(docdb): i/o optimized storage type badmintoncryer/aws-cdk
2 participants
@pahud @badmintoncryer