Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(assertions): misformatted doc string causes generated docs to cut off information #27392

Closed
jishi opened this issue Oct 3, 2023 · 6 comments · Fixed by #31199
Closed

(assertions): misformatted doc string causes generated docs to cut off information #27392

jishi opened this issue Oct 3, 2023 · 6 comments · Fixed by #31199
Labels
@aws-cdk/assertions Related to the @aws-cdk/assertv2 package bug This issue is a bug. documentation This is a problem with documentation. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md hacktoberfest Good issue for hacktoberfest-ers p2

Comments

@jishi
Copy link

jishi commented Oct 3, 2023

Describe the issue

I was about to file a PR to clarify syntax for the Template.findParameters() call, but when I looked at the source, the documentation for parameters has been correct for 2 years. See this:

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/assertions/lib/template.ts#L183

However, the latest documentation for this method is missing the * info. Isn't the online documentation generated from the comments? Why is the crucial information about this omitted here?

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.assertions.Template.html#findwbrparameterslogicalid-props

@jishi jishi added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Oct 3, 2023
@github-actions github-actions bot added the @aws-cdk/assertions Related to the @aws-cdk/assertv2 package label Oct 3, 2023
@scanlonp scanlonp changed the title (module name): (short issue description) (assertions): misformatted doc string causes generated docs to cut off information Oct 3, 2023
@scanlonp
Copy link
Contributor

scanlonp commented Oct 3, 2023

I suspect that the docstring below the @param tags is messing up the doc generation. Looks like an easy fix, but this problem is somewhat widespread in that file.

@scanlonp scanlonp added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort hacktoberfest Good issue for hacktoberfest-ers and removed needs-triage This issue or PR still needs to be triaged. labels Oct 3, 2023
@0scvr
Copy link

0scvr commented Oct 4, 2023

I'd be willing to work on this and submit a PR.

@daschaa
Copy link
Contributor

daschaa commented Dec 16, 2023

@scanlonp Is there a way to generate the docs locally to test it?

@tim-finnigan tim-finnigan added the bug This issue is a bug. label Mar 14, 2024
@Exter-dg
Copy link

I would like to work on this. As someone mentioned, is there a way to generate docs locally and test the changes? How are docs generated, I wasn't able to figure that out from the code

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/assertions Related to the @aws-cdk/assertv2 package bug This issue is a bug. documentation This is a problem with documentation. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md hacktoberfest Good issue for hacktoberfest-ers p2
Projects
None yet
6 participants