Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s][containerd] container file system metrics is not supported by cadvisor for contianerd #192

Open
Tracked by #5
pingleig opened this issue Mar 23, 2021 · 0 comments
Labels
area/container Docker Container bug Something isn't working component/container-insight enhancement New feature or request

Comments

@pingleig
Copy link
Member

pingleig commented Mar 23, 2021

Follow up on #188

Background

When using containerd runtime, you will not see container filesystem metrics in structured log.
Node filesystem metrics is still there, and there is no pod filesystem metrics regardless of runtime.

    "device",
    "fstype",
    "container_filesystem_available",
    "container_filesystem_capacity",
    "container_filesystem_usage",
    "container_filesystem_utilization"

Fix

That metrics is supported in both docker and crio and the rough logic is get rootfs dir for the container, base on the storage driver do some calculation, a common helper is also used to simply walk the dir and call Stat on every file (which is also how size limit is enforced by kubelet for emptydir volume).

We might be able to contribute to upstream

@pingleig pingleig added bug Something isn't working enhancement New feature or request component/container-insight area/container Docker Container labels Mar 23, 2021
pingleig added a commit to pingleig/amazon-cloudwatch-agent that referenced this issue Mar 24, 2021
It's a bit annoying ... but it helps when user turn on debug log
pingleig added a commit that referenced this issue Mar 24, 2021
It's a bit annoying ... but it helps when user turn on debug log
@pingleig pingleig pinned this issue Jul 20, 2021
@pingleig pingleig changed the title [k8s] container file system metrics is not supported by cadvisor for contianerd [k8s][containerd] container file system metrics is not supported by cadvisor for contianerd Jul 20, 2021
sky333999 pushed a commit that referenced this issue Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/container Docker Container bug Something isn't working component/container-insight enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant