Make server side network adaptation the default when creating VideoPriorityBasedPolicy
#2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riorityBasedPolicy`
hensmi-amazon
commented
May 3, 2024
| @@ -20,7 +20,9 @@ export default class PaginationManager<Type> { | |||
| } | |||
|
|
|||
| remove(toRemove: Type) { | |||
| this.all.splice(this.all.indexOf(toRemove)); | |||
| if (this.all.includes(toRemove)) { | |||
There was a problem hiding this comment.
Some unrelated pagination fixes here
| /** [[VideoAdaptiveProbePolicy]] wraps [[VideoPriorityBasedPolicy]] with customized behavior to automatically | ||
| * assign a high preference to content share. | ||
| * | ||
| * @deprecated This class is not compatible with latest priority policy features (i.e. server side network adaptation), |
There was a problem hiding this comment.
- Since we are trying to help the builder with the documenation, probably a link to follow when we say "can be done trivially by the application" would be helpful.
- This seems like a good detail for changelog entry as a build can understand the change better.
There was a problem hiding this comment.
actually i misunderstood a comment i wrote before/how this is used (when simulcast is enabled but a policy is not set). I don't need to deprecate this yet.
hensmi-amazon
force-pushed
the
ssna-default
branch
from
45cd1ef
to
6e287b1
Compare
hensmi-amazon
force-pushed
the
ssna-default
branch
from
6e287b1
to
50c3b5c
Compare
devalevenkatesh
previously approved these changes
May 6, 2024
hensmi-amazon
force-pushed
the
ssna-default
branch
from
deafb07
to
ed452df
Compare
hensmi-amazon
commented
May 7, 2024
| if (attendeesToShow.includes(videoTile.attendeeId)) { | ||
| videoTile.show(false); | ||
| } else if (this.tileIndexToTileId[index] !== this.findContentTileId()) { // Always show content |
There was a problem hiding this comment.
This breaks because of the local content that automatically makes a tile. It doesn't really need to make UX decisions like this (not like UX eng ever assisted with demo) so simpler is better IMO
devalevenkatesh
approved these changes
May 7, 2024
hensmi-amazon
added a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: None
Description of changes: We are no longer iterating on the priority policy without server side network adaptation. So it makes sense that it is the default.
Testing:
Confirmed that SSNA is used when not configured.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
N/A no behavior is changed.
Checklist:
Have you successfully run
npm run build:releaselocally?y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.