Fix endpoint override for demo deployment #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chitz
reviewed
Jan 6, 2024
| @@ -11,7 +11,7 @@ let app = `meetingV2`; | |||
| let useEventBridge = false; | |||
| let enableTerminationProtection = false; | |||
| let disablePrintingLogs = false; | |||
| let chimeSDKMeetingsEndpoint = 'https://service.chime.aws.amazon.com'; | |||
| let chimeSDKMeetingsEndpoint = 'https://meetings-chime.us-east-1.amazonaws.com'; | |||
There was a problem hiding this comment.
Should we generate the endpoint based on region?
There was a problem hiding this comment.
Ideally yes but these values are default value and the default region value is us-east-1 so it does not make any difference.
| const chimeSDKMediaPipelines = new ChimeSDKMediaPipelines({ region: 'us-east-1' }); | ||
| chimeSDKMediaPipelines.endpoint = process.env.CHIME_SDK_MEDIA_PIPELINES_ENDPOINT || "https://media-pipelines-chime.us-east-1.amazonaws.com" | ||
| const chimeSDKMediaPipelines = new ChimeSDKMediaPipelines({ | ||
| region: 'us-east-1', |
There was a problem hiding this comment.
Should we use currentRegion her as well?
There was a problem hiding this comment.
I think SDK media pipeline is currently hard-coded to us-east-1 by default. Thought about fixing it but decided not to as it is not related to this PR which is just to fix endpoint syntax for the SDK client.
devalevenkatesh
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix endpoint override for demo deployment. After migrating to aws sdk js v3, the previous syntax for override endpoint did not work.
Testing:
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Testing serverless demo with overriden endpoint
Checklist:
Have you successfully run
npm run build:releaselocally? YesDo you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? N/A
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.