Fix messagingSession infinite reconnect loop on error and also add backwards compatibility with AWS JS SDK V2 for getMessagingSessionEndpoint #2444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
#2372
Description of changes:
Testing:
Tested reconnect loop fix by expiring credentials to validate reconnect loop on messagingSession breaks after the timeout
Tested compatibility with aws sdk v2 by changing the chime client instantiation in the messagingSession demo
Set aws credentials with in correct aws session token
Run the messagingSession demo here: https://github.com/aws/amazon-chime-sdk-js/tree/main/demos/browser. npm run start --app=messagingSession
connect with an app instance user
Reconnect loop is triggered but breaks after timeout
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
To Test aws js sdk v2 compatibility run the messagingSession demo with below changes
Make the following changes in amazon-chime-sdk-js/demos/browser/app/messagingSession/messagingSession.ts
and change
To Test aws js sdk v3 with v2 style run the messagingSession demo with below changes
Make the following changes in amazon-chime-sdk-js/demos/browser/app/messagingSession/messagingSession.ts
and
and then run
Checklist:
Have you successfully run
npm run build:release
locally?yes
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
no
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
no
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
yes