Disable 480p downscale resolution for Chromium browsers on Windows OS #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justindarc
reviewed
Feb 10, 2022
justindarc
reviewed
Feb 10, 2022
src/videouplinkbandwidthpolicy/NScaleVideoUplinkBandwidthPolicy.ts
Outdated
Show resolved
Hide resolved
xuesichao
reviewed
Feb 10, 2022
justindarc
previously approved these changes
Feb 10, 2022
| transceiverController.setVideoInput(new MediaStreamTrack()); | ||
| const numParticipants = 5; | ||
| const expectedParams = new DefaultVideoCaptureAndEncodeParameter( | ||
| 320, |
There was a problem hiding this comment.
How were these values calculated? I'm not to familiar with NScale, but 320x192 seems like an odd resolution.
There was a problem hiding this comment.
Oh this is just a dummy test case. We do not actually use it at all. The key factor is actual the scale down resolution.
LeviSklaroff
approved these changes
Feb 10, 2022
xuesichao
approved these changes
Feb 10, 2022
simmkyu
reviewed
Feb 10, 2022
| @@ -279,6 +279,10 @@ export default class DefaultBrowserBehavior implements BrowserBehavior, Extended | |||
| return this.isAndroid(); | |||
| } | |||
|
|
|||
| disable480pResolutionScaleDown(): boolean { | |||
| return /( Chrome\/98\.)/i.test(navigator.userAgent) && this.browser.os.startsWith('Windows'); | |||
There was a problem hiding this comment.
Is this bug reproducible in Chromium? If yes, have we tested this user agent in Chromium on Windows, e.g., Electron?
There was a problem hiding this comment.
We only tested in Edge and Chrome. Chime App uses Electron and I think they did a similar fix. But yeah it affects all Chromium browsers on Windows.
ltrung
added a commit
that referenced
this pull request
Feb 10, 2022
ltrung
added a commit
that referenced
this pull request
Feb 10, 2022
ltrung
added a commit
that referenced
this pull request
Feb 10, 2022
ltrung
added a commit
that referenced
this pull request
Feb 10, 2022
ltrung
added a commit
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2002:
In Chrome 98 and Windows, videos appear grayscale for 480p when there are 5-8 videos on the call (except the active speakers) and hardware acceleration is on. This issue can be mitigated by turn off hardware acceleration.
Description of changes:
Check if its Chrome 98 and Windows OS then downscale to 360p for 5-8 videos instead of 480p.
Testing:
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Yes.
Test with Chrome, Edge, and Opera on Windows.
Checklist:
Have you successfully run
npm run build:releaselocally?Yes
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
Yes. Add a helper function in browser behavior to check whether 480p needs to be disabled.
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.