Add even more detail to the comment #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nainkunal933
previously approved these changes
Dec 27, 2021
hensmi-amazon
force-pushed
the
clarify-comment-2
branch
from
d95b601
to
d671e0f
Compare
| @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Fixed | |||
|
|
|||
| ### Changed | |||
| - Clarified a comment in `DefaultSimulcastUplinkPolicy`. | |||
There was a problem hiding this comment.
I do not think you need a CHANGELOG update for changes that do not effect builders.
There was a problem hiding this comment.
@ltrung can you verify?
There was a problem hiding this comment.
Unfortunately as long as you touch src folder you need CHANGELOG :D
ltrung
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: None
Description of changes: Didn't find the comment entirely helpful and had a question on it so rewrote this section a bit.
Testing:
n/a
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Checklist:
Have you successfully run
npm run build:releaselocally?y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.