-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split deploy canary demo script into smaller scripts #1867
Conversation
I think you have the right idea - I think you want 3 jobs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you commit the logout file by mistake?
@ltrung lockfile was added as i had to provide executable access to deploy_canary_demo script. As i removed and then added it again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the logout.js committed by mistake?
@ltrung The logout.js was added as i deleted the deploy_demo_canary script and when i added it back i had to provide executable access and that added logout.js |
ccb5f51
to
373129e
Compare
Need to rebase and then force push again. LGTM otherwise - @ltrung @devalevenkatesh any concerns? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need prod canary? If so should you update the postrelease script which release prod demo app.
…-chime-sdk-js into SplitDeployCanaryDemo
we do not need prod canaries as Gamma Canaries are testing ChimeMeetingSDK prod endpoints |
Issue #:
After adding deployment of ChimeSDKMeetings specific demos to
Deploy Canary Demo
GitHub Action which works on merging into master branch the average deployment time increased from 25 minutes to 1 hour.Description of changes:
deploy-canary-demo
script which builds browser demo and deploys serveless demo to all the canary regions and split it into region specific scripts:a) build-browser-demo
b) deploy-canary-demo-alpha
c) deploy-canary-demo-beta
d) deploy-canary-demo-gamma
deploy.yml
to add multiple jobs to run all the above scripts in parallelTesting:
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
No
Checklist:
Have you successfully run
npm run build:release
locally?Yes
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.