Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split deploy canary demo script into smaller scripts #1867

Merged
merged 5 commits into from
Dec 20, 2021

Conversation

harshitOberoi
Copy link
Contributor

Issue #:
After adding deployment of ChimeSDKMeetings specific demos to Deploy Canary Demo GitHub Action which works on merging into master branch the average deployment time increased from 25 minutes to 1 hour.

Description of changes:

  1. Removed deploy-canary-demo script which builds browser demo and deploys serveless demo to all the canary regions and split it into region specific scripts:
    a) build-browser-demo
    b) deploy-canary-demo-alpha
    c) deploy-canary-demo-beta
    d) deploy-canary-demo-gamma
  2. Updated deploy.yml to add multiple jobs to run all the above scripts in parallel

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.
No

Checklist:

  1. Have you successfully run npm run build:release locally?
    Yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
script/deploy-stanup-demo Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@michhyun1
Copy link
Contributor

michhyun1 commented Dec 10, 2021

I think you have the right idea - I think you want 3 jobs:

  1. deploy_alpha_demo
  • checkout package
  • install SAM
  • run alpha demo deploy script (cd into demo, npm i, npm build, set alpha aws creds, deply)
  1. deploy_beta_demo
  • checkout package
  • install SAM
  • run beta demo deploy script (cd into demo, npm i, npm build, set beta aws creds, deply)
  1. deploy_gamma_demo
  • checkout package
  • install SAM
  • run gamma demo deploy script (cd into demo, npm i, npm build, set gamma aws creds, deply)

Copy link
Contributor

@ltrung ltrung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you commit the logout file by mistake?

script/deploy-canary-demo Outdated Show resolved Hide resolved
@harshitOberoi
Copy link
Contributor Author

@ltrung lockfile was added as i had to provide executable access to deploy_canary_demo script. As i removed and then added it again

Copy link
Contributor

@ltrung ltrung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the logout.js committed by mistake?

@harshitOberoi
Copy link
Contributor Author

@ltrung The logout.js was added as i deleted the deploy_demo_canary script and when i added it back i had to provide executable access and that added logout.js

@michhyun1
Copy link
Contributor

Need to rebase and then force push again. LGTM otherwise - @ltrung @devalevenkatesh any concerns?

Copy link
Contributor

@ltrung ltrung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need prod canary? If so should you update the postrelease script which release prod demo app.

@harshitOberoi
Copy link
Contributor Author

we do not need prod canaries as Gamma Canaries are testing ChimeMeetingSDK prod endpoints

@harshitOberoi harshitOberoi merged commit 2ebe859 into master Dec 20, 2021
@harshitOberoi harshitOberoi deleted the SplitDeployCanaryDemo branch December 20, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants