Update NScale uplink initial encoder params #1862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: No Issue
Description of changes:
While testing I found the default uplink bitrate was exceeding the default max bitrate for the stream when using the NScaleVideoUplinkBandwidthPolicy. While monitoring the calls to RTCRtpSender.setParameters I noticed they weren't being set initially.
A mismatch in the constructor seems to be the root cause. the optimalParameters value has a max bitrate of 0 but the encodingParamMap has a maxBitrate of 1400 (the default of idealMaxBandwidthKbps).
When the initial update for the stream was received, no call was made to WebRTC since the uplink policy believed it was no changes have been made.
This update changes the constructor to bring the bitrate values in optimalParameters and encodingParamMap into alignment.
Testing:
I verified the change brought the externally measured uplink bitrate to the expected 1400kbps. I then added a unit test to ensure setEncodingParameters is called on the first update when the default ideal bitrate is used.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Checklist:
Have you successfully run
npm run build:release
locally?Yes
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
No
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.