Updated the documentation for Echo Reduction #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltrung
reviewed
Dec 3, 2021
ltrung
reviewed
Dec 3, 2021
guides/09_Amazon_Voice_Focus.md
Outdated
|
|
||
| To create meetings, the following line of code is used to address the namespace: | ||
|
|
||
| ```typescript |
There was a problem hiding this comment.
Since you are not using typescript, we can use just js or javascript I think.
There was a problem hiding this comment.
May be you can update the rest of the doc if not using types, but up to you if you want to change or you want to keep it.
nainkunal933
reviewed
Dec 7, 2021
nainkunal933
reviewed
Dec 7, 2021
nainkunal933
reviewed
Dec 7, 2021
nainkunal933
reviewed
Dec 7, 2021
simmkyu
reviewed
Dec 7, 2021
devalevenkatesh
approved these changes
Dec 7, 2021
simmkyu
reviewed
Dec 7, 2021
|
|
||
| Create your meeting by calling the CreateMeeting API and specifying the Echo Reduction flag as `'AVAILABLE'`. | ||
|
|
||
| ```typescript | ||
| // You must migrate to the Amazon Chime SDK Meetings namespace. | ||
| const chime = AWS.ChimeSDKMeetings({ region: "eu-central-1" }); |
There was a problem hiding this comment.
nit: Use single quotes for consistency with other strings in this example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
The Echo Reduction documentation needed to be updated to help users change the namespace to the Amazon Chime Meetings SDK
Description of changes:
Added the documentation to show users how to change the namespace to Amazon Chime Meetings SDK to use Echo Reduction.
Testing:
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Checklist:
Have you successfully run
npm run build:releaselocally?Yes
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
No
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.