Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable github workflow job for echo reduction integration tests #1832

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

hekmatba
Copy link
Contributor

@hekmatba hekmatba commented Nov 24, 2021

Issue #:
Echo Reduction integration test Github workflow job was disabled due to unreleased dependencies.

Description of changes:
Enable the workflow job by uncommenting these lines.

Testing:
Ran the integration test locally and will check if 'Audio and Video Transforms Integration Workflow' workflow is passing for this pull request.
Update: Audio and Video Transforms Integration Workflow have passed.

Can these tested using a demo application? Please provide reproducible step-by-step instructions.
No

Checklist:

  1. Have you successfully run npm run build:release locally?
    Yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
    No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
    No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hekmatba hekmatba requested a review from a team as a code owner November 24, 2021 22:11
@michhyun1
Copy link
Contributor

lgtm

@hekmatba hekmatba merged commit c5d8a5f into master Nov 24, 2021
@hekmatba hekmatba deleted the enable_echo_reduction_workflow branch November 24, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants