Add error name for custom device controller error #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuesichao
previously approved these changes
Nov 20, 2021
devalevenkatesh
previously approved these changes
Nov 20, 2021
4 tasks
ltrung
dismissed stale reviews from devalevenkatesh and xuesichao
via
d3b21a0
ltrung
force-pushed
the
set-device-error-name
branch
from
b415898
to
d3b21a0
Compare
devalevenkatesh
approved these changes
Nov 24, 2021
xuesichao
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1804:
Description of changes:
We have several custom error for
GetUserMediabut we did not set the name property so they all have the generic "Error" property.Testing:
Unit test
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Type ErrorChecklist:
Have you successfully run
npm run build:releaselocally? YesDo you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.