-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix priority downlink policy bandwidth estimation metrics to work with Safari #1783
Conversation
959c10e
to
1224701
Compare
@@ -191,23 +192,23 @@ export default class VideoPriorityBasedPolicy implements VideoDownlinkBandwidthP | |||
this.prevDownlinkStats = this.downlinkStats; | |||
this.downlinkStats = new LinkMediaStats(); | |||
const metricReport = clientMetricReport.getObservableMetrics(); | |||
this.downlinkStats.bandwidthEstimateKbps = metricReport.availableReceiveBandwidth / 1000; | |||
if (!isNaN(metricReport.availableOutgoingBitrate)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect
1224701
to
993a5cf
Compare
@@ -191,23 +192,23 @@ export default class VideoPriorityBasedPolicy implements VideoDownlinkBandwidthP | |||
this.prevDownlinkStats = this.downlinkStats; | |||
this.downlinkStats = new LinkMediaStats(); | |||
const metricReport = clientMetricReport.getObservableMetrics(); | |||
this.downlinkStats.bandwidthEstimateKbps = metricReport.availableReceiveBandwidth / 1000; | |||
if (!isNaN(metricReport.availableOutgoingBitrate)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect
993a5cf
to
cf7b805
Compare
Issue #:
The current priority-based downlink policy uses webRTC's available downlink bandwidth estimate to calculate whether it should pause video tiles to reserve bandwidth. However, the current implementation only checks stats from Chrome and not from other browser.
Description of changes:
Update to read stats from Safari. Firefox did not support
availableOutgoingBitrate
at this point so update the guide to clarify that instead.Testing:
Test priority-based downlink policy and check the bandwidth estimate to be correct (previously it is always null).
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Checklist:
Have you successfully run
npm run build:release
locally? YesDo you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.