Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark optional for new constructors and interface in clientMetricReport #1304

Merged
merged 2 commits into from
May 20, 2021

Conversation

ldai1
Copy link
Contributor

@ldai1 ldai1 commented May 19, 2021

Issue #:
Previously submitted a pr which has breaking changes for exposing video metrics: #1251

Description of changes:
This change is to make some attribute in DefaultClientMetricReport optional and make getObersableVideoMetricReport interface optional.

Also pass in attendeeId instead of audioVideoController to DefaultClientMetricReport.
Testing

  1. Have you successfully run npm run build:release locally? yes
  2. How did you test these changes? test in meeting demo app
  3. Can these changes be tested using the demo application? If yes, which demo application can be used to test it? meetingV2
  4. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? yes
  5. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? no

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ltrung
ltrung previously approved these changes May 19, 2021
@devalevenkatesh devalevenkatesh merged commit ab5ffeb into master May 20, 2021
@devalevenkatesh devalevenkatesh deleted the bugFix branch May 20, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants