Skip to content

Commit

Permalink
Fix content share issue with ssna change (#2692)
Browse files Browse the repository at this point in the history
  • Loading branch information
hensmi-amazon authored and simmkyu committed Jun 27, 2023
1 parent e4e9c89 commit 64a3f79
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Set max bitrate to 1500kbps.
- Add resolution constraint to content share (1080p@30fps).
- Added opt-in server side network adaption enablement flag `ServerSideNetworkAdaption.BandwidthProbingAndRemoteVideoQualityAdaption`. See [this section in the guide](https://aws.github.io/amazon-chime-sdk-js/modules/prioritybased_downlink_policy.html#server-side-network-adaption) for more details.
- Content share issue with above change

### Removed

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default class NScaleVideoUplinkBandwidthPolicy implements VideoUplinkBand
180,
];

private numberOfPublishedVideoSources: number | undefined = 0;
private numberOfPublishedVideoSources: number | undefined = undefined;
private optimalParameters: DefaultVideoAndEncodeParameter;
private parametersInEffect: DefaultVideoAndEncodeParameter;
private idealMaxBandwidthKbps = 1500;
Expand All @@ -64,7 +64,7 @@ export default class NScaleVideoUplinkBandwidthPolicy implements VideoUplinkBand

reset(): void {
// Don't reset `idealMaxBandwidthKbps` or `hasBandwidthPriority` which are set via builder API paths
this.numberOfPublishedVideoSources = 0;
this.numberOfPublishedVideoSources = undefined;
this.optimalParameters = new DefaultVideoAndEncodeParameter(0, 0, 0, 0, false);
this.parametersInEffect = new DefaultVideoAndEncodeParameter(0, 0, 0, 0, false);
this.encodingParamMap.set(NScaleVideoUplinkBandwidthPolicy.encodingMapKey, {
Expand Down

0 comments on commit 64a3f79

Please sign in to comment.