Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Update 103 to include both CPU and memory limits, fixes #574 #575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update 103 to include both CPU and memory limits, fixes #574 #575

wants to merge 1 commit into from

Conversation

parsiya
Copy link

@parsiya parsiya commented Feb 2, 2019

Fixes #574

Description of changes:

I am going through the tutorial right now and found some discrepancies.

  1. In Create resources with ResourceQuota in 103, we set a ResourceQuota for both CPU and memory limit.
  2. Next, we attempt to create a Pod without any limits and get an error.
    • The error is outdated.
      • It is: failed quota: quota: must specify memory,
      • Should be: failed quota: quota: must specify cpu,memory. This is fixed.
  3. Next, we attempt to create a Pod with only a memory limit and we claim it works.
    • It does not, we need to specify both a memory limit and a CPU limit. This is fixed.
  4. Under Get more details about the ResourceQuota: the output of kubectl describe quota/quota says 400m in front of CPU.
    • It should be 1. This is fixed.
  5. It's explained that due to a bug in Kubernetes, we do not need to specify both a CPU and a memory limit.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Create resources with ResourceQuota" uses a pod with only a memory limit - should also have a cpu limit
1 participant