Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple 1click-hpc clusters with the same FSx will crash enginframe #27

Open
rvencu opened this issue Jun 29, 2022 · 6 comments
Open

Comments

@rvencu
Copy link
Contributor

rvencu commented Jun 29, 2022

Since the /fsx/nice location is not unique to the cluster, starting multiple clusters with the same fsx will overwrite the portal data for older clusters

@nicolaven
Copy link
Contributor

yes, right. we could consider using something like /fsx/nice/{instanceID}/ instead.
what do you think ?

@rvencu
Copy link
Contributor Author

rvencu commented Jul 7, 2022 via email

@rvencu
Copy link
Contributor Author

rvencu commented Jul 7, 2022

or what about cluster name that has to be unique anyway?

"export CLUSTER_NAME=${AWS::StackName}"

@nicolaven
Copy link
Contributor

yes this is an option because the module that install EF backup an existing EF installation. So you are fine deleting an old cluster a creating a new one with the same name mounting the same FSx.

@rvencu
Copy link
Contributor Author

rvencu commented Jul 12, 2022

on the post.install.sh, line 62
export NICE_ROOT=$(jq --arg default "${SHARED_FS_DIR}/nice/${stack_name}" -r '.post_install.enginframe | if has("nice_root") then .nice_root else $default end' "${dna_json}")

and on 10.install.enginframe.headnode.sh line 60

    if [[ -d "${SHARED_FS_DIR}/nice/${stack_name}" ]]; then
        mv  -f "${SHARED_FS_DIR}/nice/${stack_name}" "${SHARED_FS_DIR}/nice/${stack_name}.$(date "+%d-%m-%Y-%H-%M").BAK"
    fi

then multiple clusters can live side by side with the enginframe portals intact

@nicolaven
Copy link
Contributor

yep! can you sent a PR specifically with this modification so I can incorporante

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants