feat: Terraform example #1478

skal111 · 2023-10-13T14:33:27Z

Issue #, if available:
#1445

Description of changes:

Terraform example
TFLint and validate in the pr-build.yml
Included remarks from previous PR

Checklist

[ X ] Meet tenets criteria
[ X ] Update tests
[ X ] Update docs
PR title follows conventional commit semantics

Breaking change checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Feat/terraform examples

backlog

Merge base

…pi URL

jeromevdl · 2023-10-13T14:39:35Z

.github/workflows/pr_build.yml

+          terraform -version
+          cd examples/powertools-examples-core/terraform
+          terraform init
+          terraform validate


should we do a plan too ?

Your call, if you think it adds value to the build.

terraform plan was added but terraform validate fails because there are no AWS credentials available in the CI environment. They are required by terraform AWS provider.
I tried, but was unsuccesful at adding

name: Setup AWS credentials
uses: aws-actions/configure-aws-credentials@5fd3084 # v2.2.0

I can't reproduce this error in my environment so I'm struggling to fix it.

I suggest we simply configure the provider with region = "us-east-1" (or any other region) as it seems to pass

maybe because you don't have permission to do that as it's from a fork

examples/powertools-examples-core/terraform/infra/variables.tf

examples/powertools-examples-core/terraform/src/test/java/helloworld/AppTest.java

jeromevdl

still a few comments

scottgerring · 2023-10-13T14:50:39Z

Related to #1458

scottgerring · 2023-10-13T15:08:18Z

My previous comments were addressed! @skal111 do you mind updating the same PR next time, it makes it easier to see what's happened 💪

skal111 · 2023-10-13T15:15:19Z

My previous comments were addressed! @skal111 do you mind updating the same PR next time, it makes it easier to see what's happened 💪

Yeah ok apologies, just found out you can update a PR :)
There you go.
Latest commit includes fixes relevant to this PR conversation

jeromevdl · 2023-10-16T07:40:24Z

@skal111, there is a problem in the latest build, with the plan (here). Don't know if we can leverage the same technic as the E2E tests (see here) to assume a role and have terraform plan working.

…nged tf providers to pass tf validate

codecov-commenter · 2023-10-16T12:20:09Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (533ac9a) 78.58% compared to head (9019e73) 78.58%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #1478   +/-   ##
=========================================
  Coverage     78.58%   78.58%           
  Complexity      650      650           
=========================================
  Files            74       74           
  Lines          2508     2508           
  Branches        259      259           
=========================================
  Hits           1971     1971           
  Misses          455      455           
  Partials         82       82

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…pi URL

…nged tf providers to pass tf validate

examples/powertools-examples-core/terraform/pom.xml

jeromevdl

Good job thank you!

jeromevdl · 2023-10-19T07:16:35Z

.github/workflows/pr_build.yml

@@ -68,6 +68,27 @@ jobs:
        run: |
          cd examples/powertools-examples-core/gradle
          ./gradlew build
+      - name: Setup Terraform


Suggested change

- name: Setup Terraform

- name: Setup AWS credentials

uses: aws-actions/configure-aws-credentials@5fd3084fc36e372ff1fff382a39b10d03659f355 # v2.2.0

with:

role-to-assume: ${{ secrets.AWS_ROLE_ARN_TO_ASSUME }}

aws-region: ${{ env.AWS_REGION }}

- name: Setup Terraform

you also need to add this after the env (line 56)

permissions: id-token: write # needed to interact with GitHub's OIDC Token endpoint. contents: read

Thanks, let me try again

jeromevdl

sorry, I saw the build failing

sonarcloud · 2023-10-19T09:26:40Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Pascal Romanens and others added 7 commits October 6, 2023 14:41

#1445 first implementation of terraform core example

0a25912

#1445 updated readme to include maven instructions

1745a6b

Merge pull request #1 from skal111/feat/terraform-examples

03bce9d

Feat/terraform examples

Merge pull request #2 from aws-powertools/main

6fc3428

backlog

Merge pull request #3 from aws-powertools/main

54d9491

Merge base

#1458 fixed readme typo + removed lambda env configuration + output a…

8bf546a

…pi URL

#1458 added tflint and tf validate to the PR build

511fae3

pull-request-size bot added the size/XL label Oct 13, 2023

jeromevdl reviewed Oct 13, 2023

View reviewed changes

examples/powertools-examples-core/terraform/infra/variables.tf Outdated Show resolved Hide resolved

jeromevdl reviewed Oct 13, 2023

View reviewed changes

examples/powertools-examples-core/terraform/src/test/java/helloworld/AppTest.java Outdated Show resolved Hide resolved

jeromevdl reviewed Oct 13, 2023

View reviewed changes

scottgerring changed the title ~~#1458 including remarks from previous PR~~ feat: Terraform example Oct 13, 2023

Merge branch 'main' into main

c5bf093

Pascal Romanens added 2 commits October 13, 2023 17:13

#1458 tf plan, removed tf aws variables, removed xray from AppTest

a93a086

Merge branch 'main' of github.com:skal111/powertools-lambda-java

10fbe45

#1458 tentative fix -> tf validate fails without proper AWS credentials

db01cae

#1458 add LAMBDA_TASK_ROOT at pom level, removed tf plan for now, cha…

9019e73

…nged tf providers to pass tf validate

Pascal Romanens added 7 commits October 16, 2023 14:26

#1458 set aws credentials at the github actions level

4b83369

#1445 first implementation of terraform core example

2a63ecc

#1445 updated readme to include maven instructions

b2e6f46

#1458 fixed readme typo + removed lambda env configuration + output a…

b843ede

…pi URL

#1458 added tflint and tf validate to the PR build

f7a9747

#1458 tf plan, removed tf aws variables, removed xray from AppTest

53691a9

#1458 tentative fix -> tf validate fails without proper AWS credentials

f85f5e5

Pascal Romanens added 4 commits October 16, 2023 17:08

#1458 add LAMBDA_TASK_ROOT at pom level, removed tf plan for now, cha…

86155a9

…nged tf providers to pass tf validate

#1458 set aws credentials at the github actions level

01bbf80

#1458 revert to having a simple aws provider configuration

3f5e20a

Merge branch 'main' of github.com:skal111/powertools-lambda-java

788119d

jeromevdl reviewed Oct 17, 2023

View reviewed changes

examples/powertools-examples-core/terraform/pom.xml Outdated Show resolved Hide resolved

#1458 changed transformer

d944264

jeromevdl reviewed Oct 18, 2023

View reviewed changes

examples/powertools-examples-core/terraform/pom.xml Show resolved Hide resolved

#1458 fixed shade plugin transformer dependency

01e1388

jeromevdl approved these changes Oct 19, 2023

View reviewed changes

Merge branch 'main' into main

c552a5c

jeromevdl reviewed Oct 19, 2023

View reviewed changes

#1458 enabled aws credentials in github action

5648cb0

jeromevdl merged commit 34fc20e into aws-powertools:main Oct 23, 2023
7 of 15 checks passed

jeromevdl mentioned this pull request Oct 23, 2023

Examples: Add a terraform example for core modules #1445

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Terraform example #1478

feat: Terraform example #1478

skal111 commented Oct 13, 2023 •

edited by scottgerring

Loading

jeromevdl Oct 13, 2023

skal111 Oct 13, 2023

skal111 Oct 17, 2023 •

edited

Loading

jeromevdl Oct 17, 2023

jeromevdl left a comment

scottgerring commented Oct 13, 2023

scottgerring commented Oct 13, 2023

skal111 commented Oct 13, 2023

jeromevdl commented Oct 16, 2023

codecov-commenter commented Oct 16, 2023

jeromevdl left a comment

jeromevdl Oct 19, 2023 •

edited

Loading

jeromevdl Oct 19, 2023

skal111 Oct 19, 2023

jeromevdl left a comment

sonarcloud bot commented Oct 19, 2023

-      - name: Setup Terraform
+      - name: Setup AWS credentials
+        uses: aws-actions/configure-aws-credentials@5fd3084fc36e372ff1fff382a39b10d03659f355 # v2.2.0
+        with:
+          role-to-assume: ${{ secrets.AWS_ROLE_ARN_TO_ASSUME }}
+          aws-region: ${{ env.AWS_REGION }}
+      - name: Setup Terraform

feat: Terraform example #1478

feat: Terraform example #1478

Conversation

skal111 commented Oct 13, 2023 • edited by scottgerring Loading

Description of changes:

Breaking change checklist

jeromevdl Oct 13, 2023

Choose a reason for hiding this comment

skal111 Oct 13, 2023

Choose a reason for hiding this comment

skal111 Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

jeromevdl Oct 17, 2023

Choose a reason for hiding this comment

jeromevdl left a comment

Choose a reason for hiding this comment

scottgerring commented Oct 13, 2023

scottgerring commented Oct 13, 2023

skal111 commented Oct 13, 2023

jeromevdl commented Oct 16, 2023

codecov-commenter commented Oct 16, 2023

Codecov Report

jeromevdl left a comment

Choose a reason for hiding this comment

jeromevdl Oct 19, 2023 • edited Loading

Choose a reason for hiding this comment

jeromevdl Oct 19, 2023

Choose a reason for hiding this comment

skal111 Oct 19, 2023

Choose a reason for hiding this comment

jeromevdl left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 19, 2023

skal111 commented Oct 13, 2023 •

edited by scottgerring

Loading

skal111 Oct 17, 2023 •

edited

Loading

jeromevdl Oct 19, 2023 •

edited

Loading