Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing idempotency key should not persist any data #1201

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

jeromevdl
Copy link
Contributor

Issue #, if available: #1200

Description of changes:

Checking for null idempotency key, logging a warning and avoid persisting the record

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.23 ⚠️

Comparison is base (c96c0ad) 71.20% compared to head (b4bdc91) 70.98%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1201      +/-   ##
============================================
- Coverage     71.20%   70.98%   -0.23%     
  Complexity      535      535              
============================================
  Files            71       71              
  Lines          2240     2254      +14     
  Branches        240      245       +5     
============================================
+ Hits           1595     1600       +5     
- Misses          532      540       +8     
- Partials        113      114       +1     
Impacted Files Coverage Δ
...tools/idempotency/internal/IdempotencyHandler.java 66.12% <50.00%> (-1.09%) ⬇️
.../idempotency/persistence/BasePersistenceStore.java 84.33% <68.42%> (-3.90%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scottgerring scottgerring self-requested a review June 16, 2023 07:24
Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeromevdl jeromevdl merged commit bcb99ba into master Jun 16, 2023
12 checks passed
@jeromevdl jeromevdl deleted the fix-idempotency-1200 branch June 16, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants