-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing idempotency key should not persist any data #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1201 +/- ##
============================================
- Coverage 71.20% 70.98% -0.23%
Complexity 535 535
============================================
Files 71 71
Lines 2240 2254 +14
Branches 240 245 +5
============================================
+ Hits 1595 1600 +5
- Misses 532 540 +8
- Partials 113 114 +1
☔ View full report in Codecov by Sentry. |
msailes
reviewed
Jun 15, 2023
...ain/java/software/amazon/lambda/powertools/idempotency/persistence/BasePersistenceStore.java
Outdated
Show resolved
Hide resolved
msailes
reviewed
Jun 15, 2023
...ain/java/software/amazon/lambda/powertools/idempotency/persistence/BasePersistenceStore.java
Outdated
Show resolved
Hide resolved
msailes
reviewed
Jun 15, 2023
...ain/java/software/amazon/lambda/powertools/idempotency/persistence/BasePersistenceStore.java
Outdated
Show resolved
Hide resolved
scottgerring
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1200
Description of changes:
Checking for null idempotency key, logging a warning and avoid persisting the record
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.