Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update nvidia-gpu-efa pattern #1966

Merged
merged 22 commits into from
Aug 4, 2024
Merged

refactor: Update nvidia-gpu-efa pattern #1966

merged 22 commits into from
Aug 4, 2024

Conversation

iankouls-aws
Copy link
Contributor

@iankouls-aws iankouls-aws commented Jun 21, 2024 •
edited
Loading

Description

Motivation and Context

  • Update the nvidia-gpu-efa pattern, enabling it to use an ODCR for capacity-challenged instance types.
  • Update documentation
  • Add EFA tests based on new public container

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@iankouls-aws iankouls-aws requested a review from a team as a code owner June 21, 2024 06:44
@iankouls-aws iankouls-aws changed the title Update nvidia-gpu-efa pattern refactor: Update nvidia-gpu-efa pattern Jun 21, 2024
bryantbiggs
bryantbiggs requested changes Jul 10, 2024
View reviewed changes
examples/eks-efa/README.md Outdated Show resolved Hide resolved
patterns/nvidia-gpu-efa/README.md Outdated Show resolved Hide resolved
patterns/nvidia-gpu-efa/README.md Outdated Show resolved Hide resolved
patterns/nvidia-gpu-efa/README.md Outdated Show resolved Hide resolved
patterns/nvidia-gpu-efa/README.md Outdated Show resolved Hide resolved
patterns/nvidia-gpu-efa/generate-efa-nccl-test.sh Show resolved Hide resolved
patterns/nvidia-gpu-efa/generate-efa-nccl-test.sh Outdated Show resolved Hide resolved
patterns/nvidia-gpu-efa/generate-efa-nccl-test.sh Outdated Show resolved Hide resolved
patterns/nvidia-gpu-efa/generate-efa-nccl-test.sh Show resolved Hide resolved
patterns/nvidia-gpu-efa/main.tf Outdated Show resolved Hide resolved
@bryantbiggs bryantbiggs merged commit 6facfa5 into aws-ia:main Aug 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhuguesaws mhuguesaws mhuguesaws left review comments

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iankouls-aws @bryantbiggs @mhuguesaws