Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - handled panic due to difference in InputdataConfig size #275

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ankurjha7
Copy link

Description of changes:

The change handles panic due to runtime error : index out of range . The present code accesses b.ko.Spec.InputDataConfig[index] which can throw panic if size of b.ko.Spec.InputDataConfig is smaller than a.ko.Spec.InputDataConfig

The solution checks for this condition and sets the a.ko.Spec.InputDataConfig[index].RecordWrapperType to default type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

ack-prow bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ankurjha7
Once this PR has been reviewed and has the lgtm label, please assign surajkota for approval by writing /assign @surajkota in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 22, 2024
Copy link

ack-prow bot commented May 22, 2024

Hi @ankurjha7. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Member

a-hilaly commented Jun 4, 2024

cc @aws-controllers-k8s/sagemaker-maintainer

@a-hilaly
Copy link
Member

a-hilaly commented Jun 4, 2024

cc @ryansteakley

@a-hilaly a-hilaly added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 4, 2024
@ankurjha7
Copy link
Author

/assign @a-hilaly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants