Bump aws-sdk-go to v1.50.15
#257
Conversation
suryans-commit
requested review from
surajkota and
ryansteakley
as code owners
ack-prow
bot
added
the
needs-ok-to-test
|
Hi @suryans-commit. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
ack-prow
bot
added
ok-to-test
| build_hash: 947081ffebdeefcf2c61c4ca6d7e68810bdf9d08 | ||
| go_version: go1.22.0 | ||
| version: v0.30.0 | ||
| api_directory_checksum: 62a1b01c505efd55545d306c2353b9673ce344fb | ||
| version: v0.29.2-8-g947081f |
There was a problem hiding this comment.
Please regenerate using latest code-generator version/commit
| // Sets whether all model containers deployed to the endpoint are isolated. | ||
| // If they are, no inbound or outbound network calls can be made to or from | ||
| // the model containers. | ||
| EnableNetworkIsolation *bool `json:"enableNetworkIsolation,omitempty"` |
There was a problem hiding this comment.
Not sure what's your naming convention in this controller, in some others we swap those to something like NetworkIsolationEnabled
There was a problem hiding this comment.
Seems like the convention in sagemaker controller is Enable first:
| // | ||
| // To be able to pass this role to Amazon SageMaker, the caller of this action | ||
| // must have the iam:PassRole permission. | ||
| ExecutionRoleARN *string `json:"executionRoleARN,omitempty"` |
There was a problem hiding this comment.
This field need an IAM Role reference
| ExecutionRole *string `json:"executionRole,omitempty"` | ||
| } | ||
|
|
||
| // The specifications of an instance group that you need to define. | ||
| type ClusterInstanceGroupSpecification struct { | ||
| ExecutionRole *string `json:"executionRole,omitempty"` |
There was a problem hiding this comment.
There at least 10-ich occurrences of fields that needs references in both types.go and the other resource files
| // on How to set the EULA acceptance when fine-tuning a model using the AutoML | ||
| // API (https://docs.aws.amazon.com/sagemaker/latest/dg/autopilot-create-experiment-finetune-llms.html#autopilot-llms-finetuning-api-optional-params). | ||
| type ModelAccessConfig struct { | ||
| AcceptEula *bool `json:"acceptEula,omitempty"` |
There was a problem hiding this comment.
Does this need to be
AcceptEula *bool `json:"acceptEULA,omitempty"`
If yes then we need to add that the names package in github.com/aws-controllers-k8s/pkg
config/controller/kustomization.yaml
Outdated
| @@ -6,4 +6,4 @@ kind: Kustomization | |||
| images: | |||
| - name: controller | |||
| newName: public.ecr.aws/aws-controllers-k8s/sagemaker-controller | |||
| newTag: 1.2.7 | |||
| newTag: 1.2.6 | |||
There was a problem hiding this comment.
We need to keep the same tag in here. Maybe git fetch --tags --all could help
|
/retest |
|
/retest |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
a-hilaly
changed the title
aws-sdk-go to v1.50.15
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, suryans-commit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is great, thank you @suryans-commit ! |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.