Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate the controller and pin runtime to v0.28.0 #252

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

ryansteakley
Copy link
Member

Issue #, if available:

Description of changes:
Updates ackruntime to v0.28.0 for sagemaker controller

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ryansteakley
Copy link
Member Author

/test sagemaker-unit-test

1 similar comment
@ryansteakley
Copy link
Member Author

/test sagemaker-unit-test

@a-hilaly a-hilaly changed the title update runtime to v0.28.0 Regenerate the controller and pin runtime to v0.28.0 Jan 19, 2024
@ryansteakley
Copy link
Member Author

/test sagemaker-unit-test

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryansteakley !
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
Copy link

ack-prow bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ryansteakley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,ryansteakley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit d0d9647 into aws-controllers-k8s:main Jan 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants