Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ACK runtime to v0.19.1 #158

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

vijtrip2
Copy link
Contributor

@vijtrip2 vijtrip2 commented Jun 17, 2022

Issue #, if available: aws-controllers-k8s/community#1351

Description of changes:

  • Update ACK runtime to v0.19.1
  • ignore ack system tags during tag assertion. Unable to use acktest from test-infra because of key name difference. Key vs key
  • ignore tags for ModelPackage because tags are only supported for ModelPackageGroup.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 499728d into aws-controllers-k8s:main Jun 21, 2022
generator.yaml Show resolved Hide resolved
test/e2e/tags.py Show resolved Hide resolved
@surajkota
Copy link
Member

@vijtrip2 Thanks for the PR and updating sagemaker-controller. Few questions for clarification, Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants