Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.34.0, code-generator v0.34.0 #98

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented May 2, 2024

Update to ACK runtime v0.34.0, code-generator v0.34.0



NOTE:
This PR increments the release version of service controller from v1.0.2 to v1.0.3

Once this PR is merged, release v1.0.3 will be automatically created for memorydb-controller

Please close this PR, if you do not want the new patch release for memorydb-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building memorydb-controller ====
Copying common custom resource definitions into memorydb
Building Kubernetes API objects for memorydb
Generating deepcopy code for memorydb
Generating custom resource definitions for memorydb
Building service controller for memorydb
Generating RBAC manifests for memorydb
Running gofmt against generated code for memorydb
Updating additional GitHub repository maintenance files
==== building memorydb-controller release artifacts ====
Building release artifacts for memorydb-v1.0.3
Generating common custom resource definitions
Generating custom resource definitions for memorydb
Generating RBAC manifests for memorydb

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label May 2, 2024
@ack-prow ack-prow bot requested review from a-hilaly and jljaco May 2, 2024 20:50
@a-hilaly
Copy link
Member

/retest

1 similar comment
@a-hilaly
Copy link
Member

a-hilaly commented Jul 3, 2024

/retest

@a-hilaly a-hilaly force-pushed the ack-bot/rt-v0.34.0-codegen-v0.34.0 branch from 4af5f4a to 35120be Compare July 9, 2024 01:19
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved labels Jul 9, 2024
@a-hilaly a-hilaly force-pushed the ack-bot/rt-v0.34.0-codegen-v0.34.0 branch from 35120be to 470bf9c Compare July 9, 2024 05:52
@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@a-hilaly
Copy link
Member

/retest

@a-hilaly a-hilaly force-pushed the ack-bot/rt-v0.34.0-codegen-v0.34.0 branch from 470bf9c to a44029f Compare July 15, 2024 07:58
@michaelhtm
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@a-hilaly a-hilaly force-pushed the ack-bot/rt-v0.34.0-codegen-v0.34.0 branch from a44029f to bb2b446 Compare July 16, 2024 19:03
@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@a-hilaly
Copy link
Member

a-hilaly commented Aug 1, 2024

/retest

@a-hilaly
Copy link
Member

a-hilaly commented Aug 1, 2024

/test all

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024
Copy link

ack-prow bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 5e55d0e into main Aug 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
3 participants