Add support for associating scram secrets to clusters #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ack-prow
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
TiberiuGC
changed the title
|
/test all |
1 similar comment
|
/test all |
|
/ok-to-test |
ack-prow
bot
added
the
ok-to-test
|
/retest-required |
ack-prow
bot
removed
the
do-not-merge/work-in-progress
a-hilaly
approved these changes
Aug 2, 2024
pkg/resource/cluster/hooks.go
Outdated
| ) (updated *resource, err error) { | ||
| rlog := ackrtlog.FromContext(ctx) | ||
| exit := rlog.Trace("rm.customUpdate") | ||
| defer exit(err) |
There was a problem hiding this comment.
non-blocking: i know this is something used all over the place in ack, we recently learned that the correct defer is to:
Suggested change
| defer exit(err) | |
| defer func() { exit(err) }() |
test/e2e/cluster.py
Outdated
a-hilaly
force-pushed
the
feature/associate-scram-secret
branch
from
4b987e1
to
549ac6e
Compare
a-hilaly
force-pushed
the
feature/associate-scram-secret
branch
from
549ac6e
to
1f9d83f
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, TiberiuGC The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws-controllers-k8s/community#2017
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.