-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for associating scram secrets to clusters #35
Add support for associating scram secrets to clusters #35
Conversation
Skipping CI for Draft Pull Request. |
/test all |
1 similar comment
/test all |
/ok-to-test |
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TiberiuGC You rock! Thank you!
/lgtm
pkg/resource/cluster/hooks.go
Outdated
) (updated *resource, err error) { | ||
rlog := ackrtlog.FromContext(ctx) | ||
exit := rlog.Trace("rm.customUpdate") | ||
defer exit(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking: i know this is something used all over the place in ack, we recently learned that the correct defer is to:
defer exit(err) | |
defer func() { exit(err) }() |
test/e2e/cluster.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the formatting!
4b987e1
to
549ac6e
Compare
549ac6e
to
1f9d83f
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, TiberiuGC The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available: aws-controllers-k8s/community#2017
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.