Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add refs support for various fields #123

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat: add refs support for various fields #123

merged 1 commit into from
Nov 22, 2023

Conversation

jose-fully-ported
Copy link
Contributor

Issue #, if available:

Closes aws-controllers-k8s/community#1513
Closes aws-controllers-k8s/community#1860

Description of changes:

The following fields have had refs support added:

  • CacheSubnetGroup.SubnetIDs: ec2.Subnet.Status.SubnetID
  • ReplicationGroup.CacheParameterGroupName: CacheParameterGroup.Spec.CacheParameterGroupName
  • ReplicationGroup.CacheSubnetGroupName: CacheSubnetGroup.Spec.CacheSubnetGroupName
  • ReplicationGroup.SecurityGroupIDs: ec2.SecurityGroup.Status.ID

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and vijtrip2 November 22, 2023 07:24
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 22, 2023
@ack-prow ACK Prow
Copy link

ack-prow bot commented Nov 22, 2023

Hi @jose-fully-ported. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jose-fully-ported
feat: add refs support for various fields
25e5d0b 
The following fields have had refs support added:

- CacheSubnetGroup.SubnetIDs: ec2.Subnet.Status.SubnetID
- ReplicationGroup.CacheParameterGroupName: CacheParameterGroup.Spec.CacheParameterGroupName
- ReplicationGroup.CacheSubnetGroupName: CacheSubnetGroup.Spec.CacheSubnetGroupName
- ReplicationGroup.SecurityGroupIDs: ec2.SecurityGroup.Status.ID

Closes aws-controllers-k8s/community#1513
Closes aws-controllers-k8s/community#1860
@a-hilaly
Copy link
Member

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2023
a-hilaly
a-hilaly approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @jose-fully-ported ! 👍

@ack-prow ack-prow bot added the approved label Nov 22, 2023
@a-hilaly
Copy link
Member

Ideally we want to add e2e tests for references that are managed by the same controller (elasticache-controller). But this is non-blocking since the controller is not GA.

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
@ack-prow ACK Prow
Copy link

ack-prow bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, jose-fully-ported

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 4aa7ba4 into aws-controllers-k8s:main Nov 22, 2023
6 checks passed
@jose-fully-ported jose-fully-ported mentioned this pull request Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
2 participants
@jose-fully-ported @a-hilaly