Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support tag motification #116

Merged
merged 11 commits into from
May 2, 2023

Conversation

Julian-Chu
Copy link
Contributor

@Julian-Chu Julian-Chu commented Apr 12, 2023

Issue: [Elasticache] tags not modified

Description of changes:

  • add creating status (add message and set ACK.ResourceSynced to false when replication group is being created)
    - status: "False"
      type: ACK.ResourceSynced
      message:  "replication group currently being created."
  • add syncTags and getTags
  • now sdkFind updates ko.Spec.Tags(latest status)
  • add E2E test case

some comments are copied from RDS controller

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2023
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 12, 2023
@ack-prow
Copy link

ack-prow bot commented Apr 12, 2023

Hi @Julian-Chu. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Member

/ok-to-test
/test all

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2023
@Julian-Chu Julian-Chu marked this pull request as ready for review April 13, 2023 16:42
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2023
@ack-prow ack-prow bot requested a review from nmvk April 13, 2023 16:42
@a-hilaly
Copy link
Member

/test all

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean! thank you @Julian-Chu !

non blocking nit: Not sure if we should keep util.py file, or just bring the changes of testing framework from https://github.com/aws-controllers-k8s/memorydb-controller/tree/main/test/e2e/declarative_test_fwk . Maybe even doing everything using test-infra/acktest could be a good option.

@ack-prow ack-prow bot added the approved label Apr 24, 2023
@Julian-Chu
Copy link
Contributor Author

Clean! thank you @Julian-Chu !

non blocking nit: Not sure if we should keep util.py file, or just bring the changes of testing framework from https://github.com/aws-controllers-k8s/memorydb-controller/tree/main/test/e2e/declarative_test_fwk . Maybe even doing everything using test-infra/acktest could be a good option.

thanks @a-hilaly , I am not professional in python, so need more time to investigate, plan to create new PR to refactor later. let's keep this PR small. 😄

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Sir! 🙇
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2023
@ack-prow
Copy link

ack-prow bot commented May 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, Julian-Chu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 58226da into aws-controllers-k8s:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants