-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/support tag motification #116
Feat/support tag motification #116
Conversation
Hi @Julian-Chu. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean! thank you @Julian-Chu !
non blocking nit: Not sure if we should keep util.py
file, or just bring the changes of testing framework from https://github.com/aws-controllers-k8s/memorydb-controller/tree/main/test/e2e/declarative_test_fwk . Maybe even doing everything using test-infra/acktest
could be a good option.
thanks @a-hilaly , I am not professional in python, so need more time to investigate, plan to create new PR to refactor later. let's keep this PR small. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Sir! 🙇
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, Julian-Chu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue: [Elasticache] tags not modified
Description of changes:
some comments are copied from RDS controller