Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis >=6 skip patch version compare #115

Merged
merged 4 commits into from
Apr 13, 2023
Merged

redis >=6 skip patch version compare #115

merged 4 commits into from
Apr 13, 2023

Conversation

joaquinservetto
Copy link
Contributor

@joaquinservetto joaquinservetto commented Mar 28, 2023 •
edited
Loading

Issue #, if available:

Description of changes:

The purpose of this changes is to avoid the controller to compare patch versions when Redis version is >=6, since It's managed by AWS. More details here.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2023
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 28, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 28, 2023

Hi @joaquinservetto. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Julian-Chu
Julian-Chu reviewed Mar 29, 2023
View reviewed changes
Copy link
Contributor

@Julian-Chu Julian-Chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some small suggestions.

pkg/resource/replication_group/delta_util_test.go Show resolved Hide resolved
pkg/resource/replication_group/delta_util.go Show resolved Hide resolved
@joaquinservetto joaquinservetto marked this pull request as ready for review March 30, 2023 10:15
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2023
@ack-prow ack-prow bot requested a review from RedbackThomson March 30, 2023 10:15
@Julian-Chu
Copy link
Contributor

link to issue aws-controllers-k8s/community#1737

@a-hilaly
Copy link
Member

a-hilaly commented Apr 6, 2023

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2023
jaypipes
jaypipes suggested changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution @joaquinservetto! Please do add a PR description that includes the GH issue identifier (aws-controllers-k8s/community#1737) and a summary of why you are making these changes.

Also left a couple notes inline. Thank you!

pkg/resource/replication_group/delta_util.go Outdated Show resolved Hide resolved
pkg/resource/replication_group/delta_util.go Outdated Show resolved Hide resolved
@joaquinservetto
Copy link
Contributor Author

Thanks for your reviews! @jaypipes, I included the function that you suggested and I also joined the conditional with the one for the "x" character, since this logic should work for both scenarios. Please take a look again

a-hilaly
a-hilaly approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+++

@ack-prow ack-prow bot added the approved label Apr 13, 2023
jaypipes
jaypipes approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @joaquinservetto! :)

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@ack-prow
Copy link

ack-prow bot commented Apr 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes, joaquinservetto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 9fd7f95 into aws-controllers-k8s:main Apr 13, 2023
@Julian-Chu Julian-Chu mentioned this pull request Jun 26, 2023
Closed
@cPu1 cPu1 mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian-Chu Julian-Chu Julian-Chu left review comments

@jaypipes jaypipes jaypipes approved these changes

@a-hilaly a-hilaly a-hilaly approved these changes

@kumargauravsharma kumargauravsharma Awaiting requested review from kumargauravsharma

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

@RedbackThomson RedbackThomson Awaiting requested review from RedbackThomson

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joaquinservetto @Julian-Chu @a-hilaly @jaypipes