Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.25.0, code-generator v0.25.0 #114

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Mar 22, 2023

Update to ACK runtime v0.25.0, code-generator v0.25.0



NOTE:
This PR increments the release version of service controller from v0.0.23 to v0.0.24

Once this PR is merged, release v0.0.24 will be automatically created for elasticache-controller

Please close this PR, if you do not want the new patch release for elasticache-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building elasticache-controller ====
Copying common custom resource definitions into elasticache
Building Kubernetes API objects for elasticache
Generating deepcopy code for elasticache
Generating custom resource definitions for elasticache
Building service controller for elasticache
Generating RBAC manifests for elasticache
Running gofmt against generated code for elasticache
Updating additional GitHub repository maintenance files
==== building elasticache-controller release artifacts ====
Building release artifacts for elasticache-v0.0.24
Generating common custom resource definitions
Generating custom resource definitions for elasticache
Generating RBAC manifests for elasticache

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Mar 23, 2023
@ack-prow ack-prow bot merged commit 5ea3ebc into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack-bot-autogen approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants