Update to ACK runtime v0.34.0, code-generator v0.34.0 (#135)

### Update to ACK runtime `v0.34.0`, code-generator `v0.34.0` ---------- * ACK code-generator `v0.34.0` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.34.0) * ACK runtime `v0.34.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.34.0) ---------- NOTE: This PR increments the release version of service controller from `v0.0.29` to `v0.0.30` Once this PR is merged, release `v0.0.30` will be automatically created for `elasticache-controller` **Please close this PR, if you do not want the new patch release for `elasticache-controller`** ---------- #### stdout for `make build-controller`: ``` building ack-generate ... ok. ==== building elasticache-controller ==== Copying common custom resource definitions into elasticache Building Kubernetes API objects for elasticache Generating deepcopy code for elasticache Generating custom resource definitions for elasticache Building service controller for elasticache Generating RBAC manifests for elasticache Running gofmt against generated code for elasticache Updating additional GitHub repository maintenance files ==== building elasticache-controller release artifacts ==== Building release artifacts for elasticache-v0.0.30 Generating common custom resource definitions Generating custom resource definitions for elasticache Generating RBAC manifests for elasticache ``` ---------- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
aws-controllers-k8s · May 3, 2024 · 63b9491 · 63b9491
1 parent 819f218
commit 63b9491
Show file tree

Hide file tree

Showing 35 changed files with 2,425 additions and 1,656 deletions.
diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml
@@ -1,8 +1,8 @@
 ack_generate_info:
-  build_date: "2024-01-29T07:10:55Z"
-  build_hash: 92f531cde5631865cfc3dfa778cbc9611f3a64c3
-  go_version: go1.21.5
-  version: v0.29.2
+  build_date: "2024-05-02T20:54:33Z"
+  build_hash: 14cef51778d471698018b6c38b604181a6948248
+  go_version: go1.22.0
+  version: v0.34.0
 api_directory_checksum: bd34f72147706f1dbc990acf4a6c4f6615c1bddb
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.93

diff --git a/apis/v1alpha1/zz_generated.deepcopy.go b/apis/v1alpha1/zz_generated.deepcopy.go
diff --git a/cmd/controller/main.go b/cmd/controller/main.go
diff --git a/config/controller/deployment.yaml b/config/controller/deployment.yaml
@@ -39,6 +39,8 @@ spec:
         - --enable-leader-election=$(ENABLE_LEADER_ELECTION)
         - --leader-election-namespace
         - "$(LEADER_ELECTION_NAMESPACE)"
+        - --reconcile-default-max-concurrent-syncs
+        - "$(RECONCILE_DEFAULT_MAX_CONCURRENT_SYNCS)"
         image: controller:latest
         name: controller
         ports:
@@ -72,13 +74,27 @@ spec:
           value: "false"
         - name: LEADER_ELECTION_NAMESPACE
           value: "ack-system"
+        - name: "RECONCILE_DEFAULT_MAX_CONCURRENT_SYNCS"
+          value: "1"
         securityContext:
           allowPrivilegeEscalation: false
           privileged: false
           runAsNonRoot: true
           capabilities:
             drop:
               - ALL
+        livenessProbe:
+          httpGet:
+            path: /healthz
+            port: 8081
+          initialDelaySeconds: 15
+          periodSeconds: 20
+        readinessProbe:
+          httpGet:
+            path: /readyz
+            port: 8081
+          initialDelaySeconds: 5
+          periodSeconds: 10
       securityContext:
         seccompProfile:
           type: RuntimeDefault

diff --git a/config/controller/kustomization.yaml b/config/controller/kustomization.yaml
@@ -6,4 +6,4 @@ kind: Kustomization
 images:
 - name: controller
   newName: public.ecr.aws/aws-controllers-k8s/elasticache-controller
-  newTag: 0.0.29
+  newTag: 0.0.30
diff --git a/config/crd/bases/elasticache.services.k8s.aws_cacheparametergroups.yaml b/config/crd/bases/elasticache.services.k8s.aws_cacheparametergroups.yaml
@@ -3,8 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.9.2
-  creationTimestamp: null
+    controller-gen.kubebuilder.io/version: v0.14.0
   name: cacheparametergroups.elasticache.services.k8s.aws
 spec:
   group: elasticache.services.k8s.aws
@@ -22,26 +21,37 @@ spec:
           API
         properties:
           apiVersion:
-            description: 'APIVersion defines the versioned schema of this representation
-              of an object. Servers should convert recognized schemas to the latest
-              internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
+            description: |-
+              APIVersion defines the versioned schema of this representation of an object.
+              Servers should convert recognized schemas to the latest internal value, and
+              may reject unrecognized values.
+              More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
             type: string
           kind:
-            description: 'Kind is a string value representing the REST resource this
-              object represents. Servers may infer this from the endpoint the client
-              submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
+            description: |-
+              Kind is a string value representing the REST resource this object represents.
+              Servers may infer this from the endpoint the client submits requests to.
+              Cannot be updated.
+              In CamelCase.
+              More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
             type: string
           metadata:
             type: object
           spec:
-            description: "CacheParameterGroupSpec defines the desired state of CacheParameterGroup.
-              \n Represents the output of a CreateCacheParameterGroup operation."
+            description: |-
+              CacheParameterGroupSpec defines the desired state of CacheParameterGroup.
+
+
+              Represents the output of a CreateCacheParameterGroup operation.
             properties:
               cacheParameterGroupFamily:
-                description: "The name of the cache parameter group family that the
-                  cache parameter group can be used with. \n Valid values are: memcached1.4
-                  | memcached1.5 | memcached1.6 | redis2.6 | redis2.8 | redis3.2 |
-                  redis4.0 | redis5.0 | redis6.x"
+                description: |-
+                  The name of the cache parameter group family that the cache parameter group
+                  can be used with.
+
+
+                  Valid values are: memcached1.4 | memcached1.5 | memcached1.6 | redis2.6 |
+                  redis2.8 | redis3.2 | redis4.0 | redis5.0 | redis6.x
                 type: string
               cacheParameterGroupName:
                 description: A user-specified name for the cache parameter group.
@@ -51,10 +61,10 @@ spec:
                   group.
                 type: string
               parameterNameValues:
-                description: An array of parameter names and values for the parameter
-                  update. You must supply at least one parameter name and value; subsequent
-                  arguments are optional. A maximum of 20 parameters may be modified
-                  per request.
+                description: |-
+                  An array of parameter names and values for the parameter update. You must
+                  supply at least one parameter name and value; subsequent arguments are optional.
+                  A maximum of 20 parameters may be modified per request.
                 items:
                   description: Describes a name-value pair that is used to update
                     the value of a parameter.
@@ -66,16 +76,16 @@ spec:
                   type: object
                 type: array
               tags:
-                description: A list of tags to be added to this resource. A tag is
-                  a key-value pair. A tag key must be accompanied by a tag value,
-                  although null is accepted.
+                description: |-
+                  A list of tags to be added to this resource. A tag is a key-value pair. A
+                  tag key must be accompanied by a tag value, although null is accepted.
                 items:
-                  description: A tag that can be added to an ElastiCache cluster or
-                    replication group. Tags are composed of a Key/Value pair. You
-                    can use tags to categorize and track all your ElastiCache resources,
-                    with the exception of global replication group. When you add or
-                    remove tags on replication groups, those actions will be replicated
-                    to all nodes in the replication group. A tag with a null Value
+                  description: |-
+                    A tag that can be added to an ElastiCache cluster or replication group. Tags
+                    are composed of a Key/Value pair. You can use tags to categorize and track
+                    all your ElastiCache resources, with the exception of global replication
+                    group. When you add or remove tags on replication groups, those actions will
+                    be replicated to all nodes in the replication group. A tag with a null Value
                     is permitted.
                   properties:
                     key:
@@ -93,24 +103,26 @@ spec:
             description: CacheParameterGroupStatus defines the observed state of CacheParameterGroup
             properties:
               ackResourceMetadata:
-                description: All CRs managed by ACK have a common `Status.ACKResourceMetadata`
-                  member that is used to contain resource sync state, account ownership,
+                description: |-
+                  All CRs managed by ACK have a common `Status.ACKResourceMetadata` member
+                  that is used to contain resource sync state, account ownership,
                   constructed ARN for the resource
                 properties:
                   arn:
-                    description: 'ARN is the Amazon Resource Name for the resource.
-                      This is a globally-unique identifier and is set only by the
-                      ACK service controller once the controller has orchestrated
-                      the creation of the resource OR when it has verified that an
-                      "adopted" resource (a resource where the ARN annotation was
-                      set by the Kubernetes user on the CR) exists and matches the
-                      supplied CR''s Spec field values. TODO(vijat@): Find a better
-                      strategy for resources that do not have ARN in CreateOutputResponse
-                      https://github.com/aws/aws-controllers-k8s/issues/270'
+                    description: |-
+                      ARN is the Amazon Resource Name for the resource. This is a
+                      globally-unique identifier and is set only by the ACK service controller
+                      once the controller has orchestrated the creation of the resource OR
+                      when it has verified that an "adopted" resource (a resource where the
+                      ARN annotation was set by the Kubernetes user on the CR) exists and
+                      matches the supplied CR's Spec field values.
+                      TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
+                      https://github.com/aws/aws-controllers-k8s/issues/270
                     type: string
                   ownerAccountID:
-                    description: OwnerAccountID is the AWS Account ID of the account
-                      that owns the backend AWS service API resource.
+                    description: |-
+                      OwnerAccountID is the AWS Account ID of the account that owns the
+                      backend AWS service API resource.
                     type: string
                   region:
                     description: Region is the AWS region in which the resource exists
@@ -121,14 +133,16 @@ spec:
                 - region
                 type: object
               conditions:
-                description: All CRS managed by ACK have a common `Status.Conditions`
-                  member that contains a collection of `ackv1alpha1.Condition` objects
-                  that describe the various terminal states of the CR and its backend
-                  AWS service API resource
+                description: |-
+                  All CRS managed by ACK have a common `Status.Conditions` member that
+                  contains a collection of `ackv1alpha1.Condition` objects that describe
+                  the various terminal states of the CR and its backend AWS service API
+                  resource
                 items:
-                  description: Condition is the common struct used by all CRDs managed
-                    by ACK service controllers to indicate terminal states  of the
-                    CR and its backend AWS service API resource
+                  description: |-
+                    Condition is the common struct used by all CRDs managed by ACK service
+                    controllers to indicate terminal states  of the CR and its backend AWS
+                    service API resource
                   properties:
                     lastTransitionTime:
                       description: Last time the condition transitioned from one status
@@ -154,12 +168,14 @@ spec:
                   type: object
                 type: array
               events:
-                description: A list of events. Each element in the list contains detailed
-                  information about one event.
+                description: |-
+                  A list of events. Each element in the list contains detailed information
+                  about one event.
                 items:
-                  description: Represents a single occurrence of something interesting
-                    within the system. Some examples of events are creating a cluster,
-                    adding or removing a cache node, or rebooting a node.
+                  description: |-
+                    Represents a single occurrence of something interesting within the system.
+                    Some examples of events are creating a cluster, adding or removing a cache
+                    node, or rebooting a node.
                   properties:
                     date:
                       format: date-time
@@ -179,8 +195,9 @@ spec:
               parameters:
                 description: A list of Parameter instances.
                 items:
-                  description: Describes an individual setting that controls some
-                    aspect of ElastiCache behavior.
+                  description: |-
+                    Describes an individual setting that controls some aspect of ElastiCache
+                    behavior.
                   properties:
                     allowedValues:
                       type: string