feat(addon): Add support for PodIdentityAssociations #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a-hilaly
force-pushed
the
addons/pod-identity-associations
branch
2 times, most recently
from
9c2e7bd
to
714bbbb
Compare
a-hilaly
commented
Jul 12, 2024
pkg/resource/addon/hooks.go
Outdated
Comment on lines
63
to
129
| // addonActive returns true if the supplied addib is in an active state | ||
| func addonActive(r *resource) bool { | ||
| if r.ko.Status.Status == nil { | ||
| return false | ||
| } | ||
| cs := *r.ko.Status.Status | ||
| return cs == StatusActive | ||
| } | ||
|
|
||
| // addonCreating returns true if the supplied addon is in a creating state | ||
| func addonCreating(r *resource) bool { | ||
| if r.ko.Status.Status == nil { | ||
| return false | ||
| } | ||
| cs := *r.ko.Status.Status | ||
| return cs == StatusCreating | ||
| } | ||
|
|
||
| // addonDeleting returns true if the supplied addon is in a deleting state | ||
| func addonDeleting(r *resource) bool { | ||
| if r.ko.Status.Status == nil { | ||
| return false | ||
| } | ||
| cs := *r.ko.Status.Status | ||
| return cs == StatusDeleting | ||
| } | ||
|
|
||
| // addonHasTerminalStatus returns true if the supplied addon is in a terminal state | ||
| func addonHasTerminalStatus(r *resource) bool { | ||
| if r.ko.Status.Status == nil { | ||
| return false | ||
| } | ||
| cs := *r.ko.Status.Status | ||
| for _, ts := range TerminalStatuses { | ||
| if cs == ts { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| // requeueWaitUntilCanModify returns a `ackrequeue.RequeueNeededAfter` struct | ||
| // explaining the addon cannot be modified until it reaches an active status. | ||
| func requeueWaitUntilCanModify(r *resource) *ackrequeue.RequeueNeededAfter { | ||
| if r.ko.Status.Status == nil { | ||
| return nil | ||
| } | ||
| status := *r.ko.Status.Status | ||
| return ackrequeue.NeededAfter( | ||
| fmt.Errorf("addon in '%s' state, cannot be modified until '%s'", | ||
| status, StatusActive), | ||
| ackrequeue.DefaultRequeueAfterDuration, | ||
| ) | ||
| } | ||
|
|
||
| // returnAddonUpdating will set synced to false on the resource and | ||
| // return an async requeue error to signify that the resource should be | ||
| // forcefully requeued in order to pick up the 'UPDATING' status. | ||
| func returnAddonUpdating(r *resource) (*resource, error) { | ||
| msg := "Addon is currently being updated" | ||
| ackcondition.SetSynced(r, corev1.ConditionFalse, &msg, nil) | ||
| return r, ackrequeue.NeededAfter( | ||
| fmt.Errorf("addon in '%s' state, cannot be modified until '%s'", | ||
| StatusUpdating, StatusActive), | ||
| 15, | ||
| ) | ||
| } |
There was a problem hiding this comment.
most of these functions can be easily generated... probably something to attack first before going after the the sdkUpdate generation
a-hilaly
force-pushed
the
addons/pod-identity-associations
branch
14 times, most recently
from
f15c911
to
a14aeed
Compare
This commit introduces support for `PodIdentityAssociations` in Addons CRD, enhancing the controller's capabilities to manage PIAs directly through the Addon resources. Key changes: - Bump the sdk to v1.54.1 to bring the latest API schema changes - Introduce `PodIdentityAssociations` to the addons spec - Add custom logic for 1/ extracting ServiceAccounts/RoleARNs from a given PIA association ID 2/ properly comparing two arrays of PIAs - Enhanced Addon status checks and requeue logic to ensure proper synchronization - Add some unit tests and e2e tests for Addon.PIAs
a-hilaly
force-pushed
the
addons/pod-identity-associations
branch
from
a14aeed
to
804a2d5
Compare
|
@a-hilaly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces support for
PodIdentityAssociationsin Addons CRD,enhancing the controller's capabilities to manage PIAs directly through the
Addon resources.
Key changes:
PodIdentityAssociationsto the addons specServiceAccounts/RoleARNsfrom a given PIA association IDBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.