Cleanup code and tests for package lifecycle work (#127)

* Update tsconfig to node20 * Some more fixes to BigInt * Skip lib check in created package
aws-cloudformation · Apr 23, 2024 · e656c33 · e656c33
1 parent 115b7c0
commit e656c33
Show file tree

Hide file tree

Showing 24 changed files with 3,702 additions and 5,011 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -3,10 +3,15 @@ module.exports = {
         jest: true,
         node: true,
     },
-    plugins: ['@typescript-eslint', 'prettier', 'import', 'prefer-arrow'],
+    plugins: [
+        '@typescript-eslint',
+        'prettier',
+        'import',
+        'prefer-arrow'
+    ],
     parser: '@typescript-eslint/parser',
     parserOptions: {
-        ecmaVersion: 2017,
+        ecmaVersion: 'latest',
         sourceType: 'module',
         project: './tsconfig.eslint.json',
     },
@@ -34,13 +39,16 @@ module.exports = {
         '@typescript-eslint/no-empty-function': ['warn'],
         '@typescript-eslint/no-explicit-any': ['warn'],
 
+        '@typescript-eslint/no-unused-vars': ['warn'],
+        '@typescript-eslint/no-loss-of-precision': ['warn'],
+
         // Require all imported dependencies are actually declared in package.json
         'import/no-extraneous-dependencies': ['error'],
         'import/no-unresolved': ['error'],
     },
     overrides: [
         {
-            files: ['*.js', '*.jsx'],
+            files: ['*.js', '*.jsx', '*.cjs'],
             rules: {
                 '@typescript-eslint/explicit-function-return-type': 'off',
                 '@typescript-eslint/no-unused-vars': 'off',

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -8,7 +8,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/setup-python@v4
+    - uses: actions/setup-python@v5
       with:
         python-version: 3.9
   os_build:

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -19,6 +19,7 @@ repos:
           - --fix=lf
       - id: trailing-whitespace
       - id: pretty-format-json
+        exclude: ^tsconfig.*.json
         args:
           - --autofix
           - --indent=4
@@ -56,7 +57,7 @@ repos:
         types: []
         files: (.*.js$|.*.ts$)
         additional_dependencies:
-          - eslint@6.8.0
+          - eslint@8.21.0
   - repo: local
     hooks:
       - id: pylint-local

diff --git a/jest.config.js → jest.config.cjs b/jest.config.js → jest.config.cjs
@@ -1,10 +1,16 @@
+const { ignorePatterns } = require('./.eslintrc');
+
 module.exports = {
     preset: 'ts-jest',
     testEnvironment: 'node',
-    globals: {
-        'ts-jest': {
-            ignoreCoverageForAllDecorators: true,
-        },
+    transform: {
+        '^.+\\.ts?$': [
+            'ts-jest',
+            {
+                ignoreCoverageForAllDecorators: true,
+                tsconfig: 'tsconfig.test.json',
+            },
+        ],
     },
     testRegex: '\\.test.ts$',
     testRunner: 'jest-circus/runner',